Skip to content

Aspsk/re enable smoke und kind #26153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2023
Merged

Aspsk/re enable smoke und kind #26153

merged 2 commits into from
Jun 13, 2023

Conversation

aspsk
Copy link
Contributor

@aspsk aspsk commented Jun 13, 2023

Re-enable the smoke test and the confirmance-kind test, as #25993 was merged and should have fixed those tests.

Re-enable the smoke test and the conformance-kind test for the CI.

@aspsk aspsk added the release-note/ci This PR makes changes to the CI. label Jun 13, 2023
@aspsk aspsk requested review from a team as code owners June 13, 2023 07:02
@aspsk aspsk requested a review from brlbil June 13, 2023 07:02
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.11 kind/backports This PR provides functionality previously merged into master. labels Jun 13, 2023
@maintainer-s-little-helper
Copy link

Commits b88c5e595a489b9dbad66c83ee2d1a5e792da75c, 8f07def83928c3b03da14fcdb64c63d08e021f07 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 13, 2023
@aspsk aspsk force-pushed the aspsk/re-enable-smoke-und-kind branch from 8f07def to 7d76549 Compare June 13, 2023 07:03
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 13, 2023
aspsk added 2 commits June 13, 2023 07:03
@aspsk
Revert "Set hostServices=true for smoke test"
bb8f299 
This reverts commit fb34e01.

Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
@aspsk
Revert "Temporarily disable part of the conformance-kind test"
7d76549 
This reverts commit 296303b.

Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
@aspsk
Copy link
Contributor Author

aspsk commented Jun 13, 2023

Smoke test & ConformanceKind are green (this is what this PR is about). Marking ready-to-merge

@aspsk
Copy link
Contributor Author

aspsk commented Jun 13, 2023

Smoke test & ConformanceKind are green (this is what this PR is about). Marking ready-to-merge

(upd: no, I need to wait for a review)

@aspsk aspsk added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2023
@gandro gandro merged commit 22e3800 into v1.11 Jun 13, 2023
@gandro gandro deleted the aspsk/re-enable-smoke-und-kind branch June 13, 2023 08:01
@michi-covalent michi-covalent mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

@brlbil brlbil Awaiting requested review from brlbil brlbil is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aspsk @viktor-kurchenko @gandro