[v1.13] Backport print-chart-version script for dev Helm chart push #26087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit d90803c ] [ upstream commit 2c367de ] [ Backporter's notes: - Removed github workflow. Workflow operates from main branch. - Applied /usr/bin/env hunk to the script (was treewide). ] Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Joe Stringer <joe@cilium.io>
michi-covalent
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
let's get #26086 merged first. otherwise the push chart workflow will start failing on v1.13 branch.
edit: oh it's the other way around. this one needs to go first so that the script exists 👀
|
✅ confirmed the chart version here: https://github.com/cilium/cilium/actions/runs/5224577019 ( https://quay.io/repository/cilium-charts-dev/cilium?tab=tags no need for the full CI run. let's just wait for the basic CI to finish before merging. |
chancez
approved these changes
Jun 9, 2023
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ upstream commit d90803c ]
[ upstream commit 2c367de ]
[ Backporter's notes:
Related: #25205