.github: Fail if print-chart-version.sh fails or does not exist #26086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor-kurchenko
approved these changes
Jun 9, 2023
joestringer
approved these changes
Jun 9, 2023
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
00c8640 to
863ac47
Compare
michi-covalent
approved these changes
Jun 9, 2023
|
chance tested this in a forked repo. no need to run the full CI since it only modifies .github/workflows/push-chart-ci.yaml. let's wait for the basic CI to finish, and i'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
print-chart-version.shdoesn't exist (ie: if it isn't back ported to a stable branch) the workflow does not fail, so make it fail so we don't push invalid charts.