Skip to content

Temporarily disable part of the conformance-kind test #25983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aspsk
Copy link
Contributor

@aspsk aspsk commented Jun 7, 2023

Patch two tests so that CI is green again; because currently it fails of complexity on new kernels (including all github runners). Namely:

  • conformance-kind: temporarily disable ipsec
  • smoke-test: set hostServices=true to reduce complexity
Temporarily disable part of the conformance-kind test.

@aspsk aspsk added kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI. backport/1.11 labels Jun 7, 2023
@aspsk aspsk requested review from a team as code owners June 7, 2023 11:56
@aspsk aspsk requested a review from brlbil June 7, 2023 11:56
@maintainer-s-little-helper maintainer-s-little-helper bot added the kind/backports This PR provides functionality previously merged into master. label Jun 7, 2023
@aspsk aspsk marked this pull request as draft June 7, 2023 12:24
@aspsk
Copy link
Contributor Author

aspsk commented Jun 7, 2023

I've switched this to draft, because the smoke test fails with the same symptoms, but for the different configuration. So we need a more broad solution than this.

@aspsk aspsk force-pushed the aspsk/kind-conformance-temporarily-disable-ipsec branch from 812a6b0 to e6e6770 Compare June 7, 2023 12:58
@aspsk aspsk requested a review from YutaroHayakawa June 7, 2023 13:00
@aspsk aspsk marked this pull request as ready for review June 7, 2023 13:03
@aspsk
Copy link
Contributor Author

aspsk commented Jun 7, 2023

No more tests required, as ConformanceKind1.19 and Smoke test passed.

Temporarily disable the ipsec part of the conformance-kind test, as it is
currently broken on new kernels (most probably, due to the commit [1] which
greatly increases complexity).

A proper fix would be to split bpf_lxc.c:from-container into more tail calls,
but this is work in progress.

  [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=354e8f1970f821d4952458f77b1ab6c3eb24d530

Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
@aspsk aspsk force-pushed the aspsk/kind-conformance-temporarily-disable-ipsec branch from e6e6770 to 8760199 Compare June 7, 2023 13:48
Setting hostServices=false with KPR=partial increases complexity which breaks
the SmokeTest on newer kernels. Disable it temporarily.

Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 👍

Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dylandreimerink dylandreimerink merged commit fb34e01 into v1.11 Jun 8, 2023
@dylandreimerink dylandreimerink deleted the aspsk/kind-conformance-temporarily-disable-ipsec branch June 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants