Skip to content

Pr/tp/debug svc v1.13 #25748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Pr/tp/debug svc v1.13 #25748

wants to merge 3 commits into from

Conversation

tommyp1ckles
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@tommyp1ckles
DO NOT MERGE
91bcf95 
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles
test: prevent panic on k8s services host fw test on some runs.
286f03d 
Change introduced 0e20d30 in order to
provide workaround fix for flake can panic depending on the order which
tests are run if the deploymentManager is not setup with a kubectl
object.

k8s/services already deploys Cilium with the hostfirewall enabled, so
this moves installing Cilium out of the host-few preparation step and
defers that to the caller (such as in datapath_configuration).

As well, this was causing failures with hostfw K8sServices test because
the deploymentManager Cilium install procedure is more strict regarding
the ensure the liveness of Agents health endpoints.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 29, 2023
@tommyp1ckles tommyp1ckles changed the base branch from main to v1.13 May 29, 2023 20:51
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles reopened this May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 kind/backports This PR provides functionality previously merged into master. labels May 30, 2023
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles deleted the pr/tp/debug-svc-v1.13 branch May 30, 2023 22:02
@tommyp1ckles tommyp1ckles restored the pr/tp/debug-svc-v1.13 branch May 31, 2023 04:21
@tommyp1ckles tommyp1ckles reopened this May 31, 2023
@tommyp1ckles
Copy link
Contributor Author

/test-1.26-net-next

@tommyp1ckles
DO NOT MERGE
a31b5a5 
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles
Copy link
Contributor Author

/test-1.26-net-next

@tommyp1ckles tommyp1ckles mentioned this pull request May 31, 2023
Merged
@tommyp1ckles
Copy link
Contributor Author

/test-1.26-net-next

@tommyp1ckles tommyp1ckles deleted the pr/tp/debug-svc-v1.13 branch June 9, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tommyp1ckles