envoy: Never use x-forwarded-for header, add for Cilium Ingress #25674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17e1d5c to
541509c
Compare
541509c to
8e05023
Compare
|
/test |
Envoy by default gets the source address from the `x-forwarded-for` header, if present. Always add an explicit `use_remote_address: true` for Envoy HTTP Connection Manager configuration to disable the default behavior. Also set the `skip_xff_append: true` option to retain the old behavior of not adding `x-forwarded-for` headers on cilium envoy proxy. Setting these options is not really needed for admin and metrics listeners, or most of the tests, but we add them there too in case anyone uses them as a source of inspiration for a real proxy configuration. This fixes incorrect hubble flow data when HTTP requests contain an `x-forwarded-for` header. This change has no effect on Cilium policy enforcement where the source security identity is always resolved before HTTP headers are parsed. Fixes: cilium#25630 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Do not skip adding `x-forwarded-for` in Cilium Ingress. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
df3c23c to
868dbe5
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/184/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
net-next hit known flake #24514 |
|
/test-1.26-net-next |
Closed
2 tasks
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy by default gets the source address from the x-forwarded-for header, if present. Always add an explicit
use_remote_address: truefor Envoy HTTP Connection Manager configuration to disable the default behavior.Also add
skip_xff_append: trueconfig to keep the existing behavior of not addingx-forwarded-forheaders, except for Cilium Ingress, where we now useskip_xff_append: falseto explicitly append the source IP tox-forwarded-forheader so that Hubble flow records have a trace for the original source of the traffic traversing Cilium Ingress.Fixes: #25630