Skip to content

v1.11: Fix L4LB GHA #25528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2023
Merged

v1.11: Fix L4LB GHA #25528

merged 1 commit into from
May 22, 2023

Conversation

brb
Copy link
Member

@brb brb commented May 18, 2023 •
edited
Loading

@brb
test: Use DinD in L4LB tests
046d2d6 
The DinD for the tests was introduced in [1]. However, it never made
into the v1.11 branch which made the GHA always to fail.

Fix this by taking the test.sh files from the main branch.

[1]: #22653

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.11 kind/backports This PR provides functionality previously merged into master. labels May 18, 2023
brb added a commit that referenced this pull request May 18, 2023
@brb
ci-l4lb-v1.1{1,2}: Remove helm charts
5995eac 
They are no longer needed, as thanks to [1] [2] we started to run the
L4LB in DinD instead of Kind.

[1]: #25528
[2]: #25523

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb mentioned this pull request May 18, 2023
Merged
@brb brb force-pushed the pr/brb/fix-ci-l4lb-v1.11 branch from 28e2683 to 046d2d6 Compare May 18, 2023 14:32
@brb brb marked this pull request as ready for review May 18, 2023 14:32
@brb brb requested a review from a team as a code owner May 18, 2023 14:32
@aanm
Copy link
Member

aanm commented May 22, 2023

Merging since the test this PR is fixing has passed.

@aanm aanm merged commit 1216e5b into v1.11 May 22, 2023
@aanm aanm deleted the pr/brb/fix-ci-l4lb-v1.11 branch May 22, 2023 07:04
aanm pushed a commit that referenced this pull request May 22, 2023
@brb @aanm
ci-l4lb-v1.1{1,2}: Remove helm charts
3e80530 
They are no longer needed, as thanks to [1] [2] we started to run the
L4LB in DinD instead of Kind.

[1]: #25528
[2]: #25523

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@michi-covalent michi-covalent mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brb @aanm