Skip to content

v1.12 Backports 2023-05-22 #25587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2023
Merged

v1.12 Backports 2023-05-22 #25587

merged 2 commits into from
May 26, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented May 22, 2023

Once this PR is merged, you can update the PR labels via:

for pr in 25323 25278; do contrib/backporting/set-labels.py $pr done 1.12; done

or with

make add-labels BRANCH=v1.12 ISSUES=25323,25278

@tklauser tklauser requested a review from a team as a code owner May 22, 2023 14:40
@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. backport/1.12 labels May 22, 2023
@tklauser tklauser requested a review from tommyp1ckles May 22, 2023 14:40
@tklauser
Copy link
Member Author

/test-backport-1.12

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostfw PR looks good to me. Thanks!

tommyp1ckles and others added 2 commits May 24, 2023 15:20
[ upstream commit 439a0a0 ]

First see the code comments for the full explanation.

This issue with the faulty conntrack entries when enforcing host
policies is suspected to cause the flakes that have been polluting host
firewall tests. We've seen this faulty conntrack issue happen mostly to
health and kube-apiserver connections. And it turns out that the host
firewall flakes look like they are caused by connectivity blips on
kube-apiserver's side, which error messages such as:

    error: unable to upgrade connection: Authorization error (user=kube-apiserver-kubelet-client, verb=create, resource=nodes, subresource=proxy)

This commit therefore tries to workaround the issue of faulty conntrack
entries in host firewall tests. If the flakes are indeed caused by those
faulty entries, we shouldn't see them happen anymore.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[ upstream commit 800c7ef ]

Signed-off-by: Akhil Velagapudi <4@4khil.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/v1.12-backport-2023-05-22 branch from 58c65f6 to 0d14517 Compare May 24, 2023 13:20
@tklauser
Copy link
Member Author

/test-backport-1.12

@tklauser tklauser removed the request for review from tommyp1ckles May 24, 2023 13:21
@tklauser
Copy link
Member Author

/ci-multicluster-1.12

@tklauser
Copy link
Member Author

/ci-external-workloads-v1.12

@tklauser
Copy link
Member Author

/ci-l4lb-1.12

@tklauser
Copy link
Member Author

/ci-awscni-1.12

@tklauser
Copy link
Member Author

/ci-aks-1.12

@tklauser
Copy link
Member Author

/ci-eks-1.12

@tklauser
Copy link
Member Author

/ci-gke-1.12

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 25, 2023
@squeed squeed merged commit 4989b82 into v1.12 May 26, 2023
@squeed squeed deleted the pr/v1.12-backport-2023-05-22 branch May 26, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants