Skip to content

Conversation

jrajahalme
Copy link
Member

Remove logic from Documentation/Makefile that skips building 'update-helm-values' on non-x86 platforms. This limitation is no longer needed as we use the helm toolbox image, which is available for multiple architectures.

Note to backporter: This change depends on #20236, which needs to be backported first.

Fixes: #20236

Updating documentation helm values now works also on arm64.

Remove logic from Documentation/Makefile that skips building
'update-helm-values' on non-x86 platforms. This limitation is no longer
needed as we use the helm toolbox image, which is available for multiple
architectures.

Fixes: cilium#20236
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.12 labels May 12, 2023
@jrajahalme jrajahalme requested a review from a team as a code owner May 12, 2023 14:40
@jrajahalme jrajahalme requested a review from qmonnet May 12, 2023 14:40
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrajahalme jrajahalme merged commit bfa4656 into cilium:main May 23, 2023
@sayboras sayboras mentioned this pull request May 28, 2023
10 tasks
@sayboras sayboras mentioned this pull request May 28, 2023
5 tasks
@sayboras sayboras added backport-pending/1.12 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.12 labels May 28, 2023
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

4 participants