Slim down Node handler interface #25450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
475cba0 to
440cb74
Compare
chancez
approved these changes
May 15, 2023
gandro
approved these changes
May 16, 2023
|
/test |
440cb74 to
28b58b6
Compare
|
Rebased as this picked up a conflict with upstream. |
|
/test |
YutaroHayakawa
approved these changes
May 24, 2023
This was referenced Jun 6, 2023
2 tasks
2 tasks
2 tasks
This was referenced Jun 9, 2023
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Dec 3, 2024
This commit removes unnecessary no-op functions from the `clusterNodesClient` in the nodemanager rest api handler. Related to cilium#25450 (that slimmed down the `NodeHandler` interface) Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
borkmann
pushed a commit
that referenced
this pull request
Dec 3, 2024
This commit removes unnecessary no-op functions from the `clusterNodesClient` in the nodemanager rest api handler. Related to #25450 (that slimmed down the `NodeHandler` interface) Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit by commit, though changes shouldn't be too large
I was looking into
NodeHandlerfor a related PR, and noticed that one has to stub out quite a few methods to implement the interface, even if the code is just interested in getting notifed onNode{Add,Update,Delete}. That seemed suboptimal, so this series splits theNodeHandlerinterface in three more focussed interfaces. Purely cosmetic change, no (intentional) functional changes.A next step might be to look into breaking up the
linuxNodeHandler, but that's stuff for another PR.cc @gandro