bpf: add missing drop notifications #25183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're returning a DROP reason, but nothing outside do_netdev() creates the corresponding drop notification from it. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
do_netdev_encrypt_encap() can return various errors, but its caller doesn't raise the corresponding drop notification. Also clean up the one case in do_netdev_encrypt_encap() where we currently *do* raise a drop notification. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
__encap_and_redirect_with_nodeid() expects the caller to handle this check. Otherwise we end up encapsulating with an OuterDstIP of 0.0.0.0. I looked at all the other users, looks like this was the only one missing. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Align with all the other error paths in tail_handle_arp() and raise a drop notification on error. This function is executed as a tail-call, so there's no surrounding code that would do this for us otherwise. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Add an error path for the from-netdev program that handles the missing drop notification. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Fix one more missing drop notification in the from-netdev program. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
99cf420 to
f39c436
Compare
All direct and indirect callers are now properly handling errors from this path, and raising the drop notification. So remove it from the low-level helper code. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
f39c436 to
06626ae
Compare
|
/test |
|
BPF checkpatch complains about
which was already bad before. And fixing it means triggering checkpatch again, because we're then exceeding max line width 🤷. Think I'm good leaving it as is, we're planning to remove this code during the current release cycle anyway. |
|
@ldelossa 👋 how can I help with making your review easier? |
|
One static checker complaint (#25183 (comment)) that is ok to ignore imo. The So |
3 tasks
This was referenced Jun 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End goal was to get rid of the stray drop notification that's currently buried in
__encap_and_redirect_with_nodeid(). Getting there took quite a few additional drive-by fixes :).The last two patches can be dropped from the backport (
encap_and_redirect_with_nodeid_opt()didn't exist in v1.13).