Improve clustermesh's users management test reliability #24917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the users management test uses a "sleep" with an hard-coded (low) duration to wait for the update events to be triggered after a file update. To improve reliability, let's switch to use the Eventually helper, hence retrying multiple times until the condition is satisfied, rather than waiting for a fixed amount of time. Fixes: 60f94e4 ("clustermesh-apiserver: implement users management for remote clusters") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
YutaroHayakawa
approved these changes
Apr 18, 2023
|
Marking as ready-to-merge, since reviews are in, and the integration tests passed (this PR only modifies one integration test, hence running the additional tests is superfluous). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the users management test uses a "sleep" with an hard-coded (low) duration to wait for the update events to be triggered after a file update. To improve reliability, let's switch to use the Eventually helper, hence retrying multiple times until the condition is satisfied, rather than waiting for a fixed amount of time.
Fixes: #24653