bpf: nodeport: don't track L2 addr for connection to local backend #24324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replies by a local backend either get their L2 resolution by the stack, or (when bpf_lxc uses bpf-host-routing) by bpf_redirect_neigh(). But fib_redirect_*() will never fall through to the L2 neigh cache to get the client's MAC address. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
|
Filed #24342 for the test-runtime flake, re-running. |
|
/test-runtime |
julianwiedmann
added a commit
to julianwiedmann/cilium
that referenced
this pull request
May 20, 2025
This re-introduces the optimization from cilium#24324. The reasoning back then was > Replies by a local backend either get their L2 resolution by the stack, > or (when bpf_lxc uses bpf-host-routing) by bpf_redirect_neigh(). > But fib_redirect_*() will never fall through to the L2 neigh cache to get > the client's MAC address. But this was later reverted in cilium#34303 because we had missed one case - older kernels which don't have fib_redirect_neigh(), and where Cilium thus might end up looking for the client's MAC in the neighbor map. Now that we have bumped the minimum kernel requirement to v5.10 and *require* fib_redirect_neigh() to be available, let's bring this change back. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2025
This re-introduces the optimization from #24324. The reasoning back then was > Replies by a local backend either get their L2 resolution by the stack, > or (when bpf_lxc uses bpf-host-routing) by bpf_redirect_neigh(). > But fib_redirect_*() will never fall through to the L2 neigh cache to get > the client's MAC address. But this was later reverted in #34303 because we had missed one case - older kernels which don't have fib_redirect_neigh(), and where Cilium thus might end up looking for the client's MAC in the neighbor map. Now that we have bumped the minimum kernel requirement to v5.10 and *require* fib_redirect_neigh() to be available, let's bring this change back. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replies by a local backend either get their L2 resolution by the stack, or (when bpf_lxc uses bpf-host-routing) by bpf_redirect_neigh(). But fib_redirect_*() will never fall through to the L2 neigh cache to get the client's MAC address.