Skip to content

datapath: Fix L7 reply to outside when endpoint routes disabled #21980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

datapath: Fix L7 reply to outside when endpoint routes disabled #21980

merged 1 commit into from
Jan 10, 2023

Conversation

brb
Copy link
Member

@brb brb commented Nov 2, 2022 •
edited
Loading

See commit msg.

I'm going to extend the ci-datapath in cilium-cli to cover the previously troublesome packet path.

Fix #21954

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 2, 2022
@brb
Copy link
Member Author

brb commented Nov 2, 2022

/test

@brb brb force-pushed the pr/brb/rm-2005-route-table branch from 253bdd2 to 812d269 Compare November 3, 2022 09:41
@brb
Copy link
Member Author

brb commented Nov 3, 2022

/test

@brb
Copy link
Member Author

brb commented Nov 3, 2022

/test-1.24-4.19

2 similar comments
@brb
Copy link
Member Author

brb commented Nov 3, 2022

/test-1.24-4.19

@brb
Copy link
Member Author

brb commented Nov 4, 2022

/test-1.24-4.19

@brb
Copy link
Member Author

brb commented Nov 8, 2022

/test-1.25-net-next

@brb
Copy link
Member Author

brb commented Nov 8, 2022

/test-1.24-4.19

@brb brb force-pushed the pr/brb/rm-2005-route-table branch from 812d269 to eca8b5c Compare November 10, 2022 10:30
@brb
Copy link
Member Author

brb commented Nov 10, 2022

/test

@brb brb force-pushed the pr/brb/rm-2005-route-table branch from eca8b5c to 7704e83 Compare November 29, 2022 14:32
@brb
Copy link
Member Author

brb commented Nov 29, 2022

/test

@brb brb force-pushed the pr/brb/rm-2005-route-table branch from 7704e83 to 4ccf262 Compare December 7, 2022 14:03
@brb brb force-pushed the pr/brb/rm-2005-route-table branch from 4ccf262 to 042172e Compare December 21, 2022 11:07
@brb
Copy link
Member Author

brb commented Dec 21, 2022

/test

@brb brb force-pushed the pr/brb/rm-2005-route-table branch 2 times, most recently from 642d6d0 to 67169c7 Compare January 9, 2023 10:45
@brb brb changed the title WIP: Fix L7 reply to outside datapath: Fix L7 reply to outside Jan 9, 2023
@brb brb added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. needs-backport/1.12 release-note/bug This PR fixes an issue in a previous release of Cilium. labels Jan 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2023
@brb brb requested review from jrajahalme and pchaigno January 9, 2023 10:47
@brb brb marked this pull request as ready for review January 9, 2023 10:47
@brb brb requested a review from a team as a code owner January 9, 2023 10:47
pchaigno
pchaigno approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jrajahalme
Copy link
Member

jrajahalme commented Jan 9, 2023 •
edited
Loading

Would be nice to see more specifics on when this bug manifested. Looking at the change is seems endpoint routes mode was not affected?

@brb
Copy link
Member Author

brb commented Jan 10, 2023

/mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19

@brb
Copy link
Member Author

brb commented Jan 10, 2023

/test-1.25-4.19

jrajahalme
jrajahalme approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out :-)

@brb
Copy link
Member Author

brb commented Jan 10, 2023 •
edited
Loading

/test-1.25-4.19

Docker pull errors.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2023
@borkmann borkmann merged commit 2b58e0f into master Jan 10, 2023
@borkmann borkmann deleted the pr/brb/rm-2005-route-table branch January 10, 2023 16:10
@ti-mo ti-mo mentioned this pull request Jan 13, 2023
Closed
@aanm aanm mentioned this pull request Jan 18, 2023
Merged
30 tasks
@ldelossa ldelossa mentioned this pull request Jan 19, 2023
Closed
@aanm aanm mentioned this pull request Jan 23, 2023
Merged
19 tasks
@aanm aanm added backport-pending/1.13 backport/author The backport will be carried out by the author of the PR. and removed needs-backport/1.13 labels Jan 23, 2023
@ldelossa ldelossa mentioned this pull request Jan 23, 2023
Merged
@pchaigno pchaigno mentioned this pull request Jan 24, 2023
Closed
@joestringer
Copy link
Member

Dropping backport labels due to #23346 .

@julianwiedmann julianwiedmann removed the backport/author The backport will be carried out by the author of the PR. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reply from pod to outside is dropped when L7 ingress policy is used
8 participants
@brb @jrajahalme @joestringer @pchaigno @borkmann @ti-mo @aanm @julianwiedmann