Skip to content

Remove RUNTIME=docker in dev_setup document #21940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2022
Merged

Remove RUNTIME=docker in dev_setup document #21940

merged 1 commit into from
Nov 2, 2022

Conversation

Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Oct 31, 2022 •
edited by qmonnet
Loading

We can't use RUNTIME=docker option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in #19545.

Fixes: #21935

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!
Docs: Remove `RUNTIME=docker` option in dev_setup, given that K8s 1.24+ no longer supports it (options: containerd (default), crio).

@Shunpoco Shunpoco requested review from a team as code owners October 31, 2022 14:43
@Shunpoco Shunpoco requested review from aanm and qmonnet October 31, 2022 14:43
@maintainer-s-little-helper
Copy link

Commit 16110aacd4995dc286094ea336744ccf835db7bb does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 31, 2022
@Shunpoco Shunpoco force-pushed the docs-remove-runtime-docker branch from 16110aa to ff54f83 Compare October 31, 2022 14:47
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 31, 2022
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 labels Oct 31, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 31, 2022
qmonnet
qmonnet requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit below.
Thanks a lot for contributing!

qmonnet
qmonnet approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks, would you mind squashing the two commits and force-pushing your branch please?

@Shunpoco
Remove RUNTIME=docker in dev_setup document
f3dbc94 
We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in cilium#19545.

Fixes: cilium#21935

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
@Shunpoco Shunpoco force-pushed the docs-remove-runtime-docker branch from 7c305ec to f3dbc94 Compare October 31, 2022 15:38
@Shunpoco
Copy link
Contributor Author

@qmonnet
I squashed and force-pushed. Thanks for your review!

@aanm aanm merged commit 9f37627 into cilium:master Nov 2, 2022
@Shunpoco Shunpoco deleted the docs-remove-runtime-docker branch November 4, 2022 05:33
@pchaigno pchaigno mentioned this pull request Nov 7, 2022
Merged
@michi-covalent michi-covalent mentioned this pull request Nov 16, 2022
Merged
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: need to remove RUNTIME=docker in dev_setup document
5 participants
@Shunpoco @aanm @qmonnet @joestringer @pchaigno