Skip to content

Fix incorrect env var name used in docs for Helm installation on Rancher Desktop #21835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix incorrect env var name used in docs for Helm installation on Rancher Desktop #21835

merged 1 commit into from
Oct 25, 2022

Conversation

ehausig
Copy link
Contributor

@ehausig ehausig commented Oct 21, 2022 •
edited
Loading

Signed-off-by: Eric Hausig eric.hausig+github@gmail.com

Fixes: #21834

@ehausig ehausig requested a review from a team as a code owner October 21, 2022 13:34
@ehausig ehausig requested a review from qmonnet October 21, 2022 13:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 21, 2022
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 labels Oct 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 21, 2022
qmonnet
qmonnet requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks a lot for the fix!

I have two comments:

  • Would you mind adding a link to the reference for that variable in the commit description? https://docs.k3s.io/reference/env-variables looks like a good one.
  • Would you please consider using a real email address in your Signed-off-by: tag?

@aanm aanm added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 21, 2022
@ehausig
Rename env var required to disable Flannel
36aad24 
See https://docs.k3s.io/reference/env-variables for documentation on the INSTALL_K3S_EXEC environment variable.

Signed-off-by: Eric Hausig <eric.hausig+github@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 24, 2022
@ehausig
Copy link
Contributor Author

ehausig commented Oct 24, 2022

Hi, and thanks a lot for the fix!

I have two comments:

  • Would you mind adding a link to the reference for that variable in the commit description? https://docs.k3s.io/reference/env-variables looks like a good one.
  • Would you please consider using a real email address in your Signed-off-by: tag?

Thanks for the feedback, qmonnet! I've updated the commit message. (Hopefully, I did it correctly.)

qmonnet
qmonnet approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks a lot!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 24, 2022
@aanm aanm merged commit 811bf1b into cilium:master Oct 25, 2022
@pchaigno pchaigno mentioned this pull request Nov 7, 2022
Merged
@michi-covalent michi-covalent mentioned this pull request Nov 16, 2022
Merged
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect env var name used in docs for Helm installation on Rancher Desktop
5 participants
@ehausig @qmonnet @joestringer @pchaigno @aanm