Skip to content

docs: Fix 'interface' field indentation #21798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

docs: Fix 'interface' field indentation #21798

merged 1 commit into from
Oct 19, 2022

Conversation

lou-lan
Copy link
Contributor

@lou-lan lou-lan commented Oct 19, 2022 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

Signed-off-by: lou-lan loulan@loulan.me

@lou-lan lou-lan requested a review from a team as a code owner October 19, 2022 05:59
@lou-lan lou-lan requested a review from qmonnet October 19, 2022 05:59
@maintainer-s-little-helper
Copy link

Commit c5399f3daac758c06a144a5851badf612b960b6a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 19, 2022
@lou-lan
docs: Fix 'interface' field indentation
f879f2d 
Signed-off-by: lou-lan <loulan@loulan.me>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 19, 2022
@lou-lan lou-lan closed this Oct 19, 2022
@lou-lan lou-lan reopened this Oct 19, 2022
qmonnet
qmonnet approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. feature/egress-gateway Impacts the egress IP gateway feature. labels Oct 19, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 19, 2022
@qmonnet qmonnet merged commit d623fe2 into cilium:master Oct 19, 2022
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
Merged
6 tasks
@michi-covalent michi-covalent mentioned this pull request Nov 16, 2022
Merged
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. feature/egress-gateway Impacts the egress IP gateway feature. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lou-lan @qmonnet @joestringer