Skip to content

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Oct 11, 2022

Add some additional notes to highlight how Cilium's k8s NetworkPolicy
support works, including:

  • Egress policies have not been beta for several years.
  • Port Ranges.

@joestringer joestringer requested review from a team as code owners October 11, 2022 17:58
@joestringer joestringer added needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels Oct 11, 2022
@joestringer joestringer requested review from squeed and qmonnet October 11, 2022 17:58
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 11, 2022
@joestringer joestringer requested a review from aanm October 11, 2022 17:58
@joestringer joestringer force-pushed the submit/fix-k8s-policy-doc branch from 23d6371 to 5708cc4 Compare October 11, 2022 20:36
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@qmonnet
Copy link
Member

qmonnet commented Oct 12, 2022

Spellcheck complains about endPort, can you please add it to the list of correct words?

Add some additional notes to highlight how Cilium's k8s NetworkPolicy
support works, including:

- Egress policies have not been beta for several years.
- Port Ranges.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/fix-k8s-policy-doc branch from 5708cc4 to d50be54 Compare October 12, 2022 20:54
@joestringer joestringer added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 12, 2022
@qmonnet qmonnet merged commit 6fbbbb9 into cilium:master Oct 13, 2022
@joestringer joestringer deleted the submit/fix-k8s-policy-doc branch October 18, 2022 02:29
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
6 tasks
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
3 tasks
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
3 tasks
@joestringer joestringer added backport-done/1.10 backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.10 labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants