Skip to content

v1.12: Update Go to 1.18.7 #21592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2022
Merged

v1.12: Update Go to 1.18.7 #21592

merged 2 commits into from
Oct 26, 2022

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Oct 5, 2022

No description provided.

@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact. backport/1.12 labels Oct 5, 2022
@tklauser tklauser temporarily deployed to release-base-images October 5, 2022 11:49 Inactive
@tklauser tklauser had a problem deploying to release-base-images October 5, 2022 11:49 Failure
@tklauser tklauser changed the title Update Go to 1.18.7 v1.12: Update Go to 1.18.7 Oct 5, 2022
@tklauser tklauser force-pushed the pr/tklauser/v1.12-update-go-1.18.7 branch from 1e2c87b to e900b51 Compare October 5, 2022 11:59
@tklauser tklauser temporarily deployed to release-base-images October 5, 2022 12:00 Inactive
@tklauser tklauser temporarily deployed to release-base-images October 5, 2022 12:00 Inactive
@tklauser tklauser force-pushed the pr/tklauser/v1.12-update-go-1.18.7 branch from e900b51 to df37a36 Compare October 5, 2022 12:28
@tklauser tklauser temporarily deployed to release-base-images October 5, 2022 12:28 Inactive
@tklauser tklauser temporarily deployed to release-base-images October 5, 2022 12:28 Inactive
@tklauser tklauser marked this pull request as ready for review October 5, 2022 12:28
@tklauser tklauser requested review from a team as code owners October 5, 2022 12:28
@tklauser tklauser requested review from rolinh and nbusseneau October 5, 2022 12:28
@tklauser
Copy link
Member Author

tklauser commented Oct 5, 2022 •
edited by maintainer-s-little-helper bot
Loading

/test-backport-1.12

Job 'Cilium-PR-K8s-1.18-kernel-4.9' failed:

Click to show.

Test Name

K8sPolicyTest Multi-node policy test with L7 policy using connectivity-check to check datapath

Failure Output

FAIL: cannot install connectivity-check

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.18-kernel-4.9 so I can create one.

Job 'Cilium-PR-K8s-1.20-kernel-4.9' failed:

Click to show.

Test Name

K8sDatapathConfig MonitorAggregation Checks that monitor aggregation restricts notifications

Failure Output

FAIL: Unable to retrieve all pods to restart unmanaged pods with 'kubectl -n kube-system get pods -o json': Exitcode: -1

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.20-kernel-4.9 so I can create one.

@sayboras sayboras closed this Oct 11, 2022
@sayboras sayboras reopened this Oct 11, 2022
@sayboras sayboras temporarily deployed to release-base-images October 11, 2022 05:10 Inactive
@sayboras sayboras temporarily deployed to release-base-images October 11, 2022 05:10 Inactive
@sayboras
Copy link
Member

/test-1.18-4.9

@sayboras
Copy link
Member

/test-1.20-4.9

@sayboras
Copy link
Member

/test-backport-1.12

@sayboras
Copy link
Member

/test-1.20-4.9

@pippolo84
Update Go to 1.18.7
65289af 
This version fixes security issues in the archive/tar,
net/http/httputil, and regexp packages. See the release notes [1] for
more details

    [1] https://go.dev/doc/devel/release#go1.18.7

Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
@pippolo84 pippolo84 force-pushed the pr/tklauser/v1.12-update-go-1.18.7 branch from 89195ba to 62eff63 Compare October 24, 2022 09:24
@pippolo84 pippolo84 temporarily deployed to release-base-images October 24, 2022 09:24 Inactive
@pippolo84 pippolo84 force-pushed the pr/tklauser/v1.12-update-go-1.18.7 branch from 62eff63 to c92dbb6 Compare October 24, 2022 09:36
@pippolo84 pippolo84 temporarily deployed to release-base-images October 24, 2022 09:37 Inactive
@pippolo84 pippolo84 temporarily deployed to release-base-images October 24, 2022 09:37 Inactive
@pippolo84
images: update cilium-{runtime,builder}
5d093bd 
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
@pippolo84 pippolo84 force-pushed the pr/tklauser/v1.12-update-go-1.18.7 branch from c92dbb6 to 5d093bd Compare October 24, 2022 09:51
@pippolo84 pippolo84 temporarily deployed to release-base-images October 24, 2022 09:51 Inactive
@pippolo84 pippolo84 temporarily deployed to release-base-images October 24, 2022 09:51 Inactive
@pippolo84
Copy link
Member

/test

@aanm
Copy link
Member

aanm commented Oct 24, 2022 •
edited by maintainer-s-little-helper bot
Loading

/test-backport-1.12

Job 'Cilium-PR-K8s-1.18-kernel-4.9' failed:

Click to show.

Test Name

K8sNode Node labels updates are reflected in CiliumNode objects

Failure Output

FAIL: Timed out after 10.001s.

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.18-kernel-4.9 so I can create one.

Job 'Cilium-PR-K8s-1.21-kernel-4.9' failed:

Click to show.

Test Name

K8sDemosTest Tests Star Wars Demo

Failure Output

FAIL: Found 1 k8s-app=cilium logs matching list of errors that must be investigated:

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.9 so I can create one.

@pippolo84
Copy link
Member

/ci-aks-1.12

@pippolo84
Copy link
Member

/test-1.17-4.9

1 similar comment
@pippolo84
Copy link
Member

/test-1.17-4.9

@pippolo84
Copy link
Member

/test-1.18-4.9

@pippolo84
Copy link
Member

/test-1.19-4.9

@pippolo84
Copy link
Member

/test-1.20-4.9

@pippolo84
Copy link
Member

/test-1.21-4.9

@pippolo84
Copy link
Member

/test-1.22-4.9

@pippolo84
Copy link
Member

/test-1.22-5.4

@pippolo84
Copy link
Member

/test-1.19-4.9

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 25, 2022
@pippolo84
Copy link
Member

pippolo84 commented Oct 25, 2022 •
edited
Loading

All required checks are passing, failed tests are unrelated (they were incorrectly requested with the /test comment).

@nathanjsweet nathanjsweet merged commit 5531942 into v1.12 Oct 26, 2022
@nathanjsweet nathanjsweet deleted the pr/tklauser/v1.12-update-go-1.18.7 branch October 26, 2022 16:44
@michi-covalent michi-covalent mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@ti-mo ti-mo ti-mo approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tklauser @sayboras @pippolo84 @aanm @rolinh @ti-mo @nbusseneau @nathanjsweet