bugtool: Fix pprof default ports #21497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
approved these changes
Sep 29, 2022
|
Forgot to update command reference, I'll fix it. |
gops and pprof do not use the same protocol to collect profile data. Thus, the default port for pprof debug endpoints in `cilium-bugtool` should not be the one used for gops, but the default one for pprof itself. Besides, clustermesh-apiserver does not support pprof yet, but only gops. Thus, the help message for the pprof port option in cilium-bugtool is fixed accordingly. Fixes: #416319b1cd (bugtool: Default to the agent's gops port) Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
d015a7f to
9e1917d
Compare
michi-covalent
approved these changes
Sep 29, 2022
|
/test |
|
/test-1.16-4.9 Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
christarazi
reviewed
Sep 29, 2022
|
/test-1.25-net-next Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
christarazi
approved these changes
Sep 29, 2022
jibi
approved these changes
Oct 3, 2022
|
Test failures are unrelated, reviews are in, marking ready to merge. |
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gopsandpprofdo not use neither the same protocol nor the same port to collect profile data.When
cilium-bugtoolqueries the gops server embedded in the agent, it collects the data calling the gops cli from the shell, without passing any extra port argument: https://github.com/cilium/cilium/blob/master/bugtool/cmd/root.go#L499-L506Instead, when querying the
pprofdebug endpoints,cilium-bugtoolshould use the proper agent default pprof port: https://github.com/cilium/cilium/blob/master/bugtool/cmd/root.go#L478-L497This PR changes the default port for pprof endpoints in
cilium-bugtoolto be the same default port set in the agent, even if pprof support is disabled by default in the agent.Besides, clustermesh-apiserver does not support pprof yet, but only gops. Thus, the help message for the pprof port option in cilium-bugtool is fixed accordingly.
Fixes: #17004