Skip to content

Add a section with distro-specific considerations #21064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add a section with distro-specific considerations #21064

merged 1 commit into from
Oct 21, 2022

Conversation

bmcustodio
Copy link
Contributor

Over time we've been accumulating some knowledge about particular
Linux distributions and groups of distributions that has gone largely
unnoted in our documentation. A good understanding and implementation
of these considerations are extremely important to ensure that Cilium
runs properly, so this commit attempts at adding a subsection containing
this information.

@bmcustodio bmcustodio added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels Aug 24, 2022
@bmcustodio bmcustodio requested review from gandro and borkmann August 24, 2022 08:25
@bmcustodio bmcustodio requested review from a team as code owners August 24, 2022 08:25
@bmcustodio bmcustodio requested a review from qmonnet August 24, 2022 08:25
@bmcustodio
Copy link
Contributor Author

Adding @gandro (for Flatcar) and @borkmann (for new systemd notes) as reviewers as we've discussed these in some form over time.

borkmann
borkmann approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

gandro
gandro approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! The section likely applies to any distro that's using systemd-networkd as the default, but Flatcar is the only one we've observed this so far I think.

qmonnet
qmonnet approved these changes Aug 24, 2022
View reviewed changes
aanm
aanm requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of documenting, should we instead do a PR similar to #20072?

@pchaigno pchaigno marked this pull request as draft September 15, 2022 10:37
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 16, 2022
@pchaigno pchaigno force-pushed the pr/bruno/distro-considerations branch from 98d8617 to 77e4db2 Compare October 21, 2022 09:38
@pchaigno pchaigno removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 21, 2022
@pchaigno pchaigno force-pushed the pr/bruno/distro-considerations branch from 77e4db2 to d9df091 Compare October 21, 2022 09:39
@bmcustodio @pchaigno
Add a section with distro-specific considerations
31a0f66 
Over time we've been accumulating some knowledge about particular
Linux distributions and groups of distributions that has gone largely
unnoted in our documentation. A good understanding and implementation
of these considerations are extremely important to ensure that Cilium
runs properly, so this commit attempts at adding a subsection containing
this information.

Signed-off-by: Bruno M. Custódio <brunomcustodio@gmail.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/bruno/distro-considerations branch from d9df091 to 31a0f66 Compare October 21, 2022 09:44
@pchaigno
Copy link
Member

Instead of documenting, should we instead do a PR similar to #20072?

Agree that would be ideal, but until someone has cycles for proper fixes, I think this documentation PR is a good stopgap.

@pchaigno pchaigno requested a review from aanm October 21, 2022 09:49
@pchaigno pchaigno marked this pull request as ready for review October 21, 2022 09:50
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 21, 2022
@aanm aanm merged commit e121b5d into master Oct 21, 2022
@aanm aanm deleted the pr/bruno/distro-considerations branch October 21, 2022 20:59
@pchaigno pchaigno mentioned this pull request Nov 7, 2022
Merged
@pchaigno pchaigno mentioned this pull request Nov 9, 2022
Merged
@pchaigno pchaigno mentioned this pull request Nov 9, 2022
Merged
This was referenced Nov 15, 2022
Merged
Closed
Merged
Merged
@joestringer joestringer added backport-done/1.10 backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.10 labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@gandro gandro gandro approved these changes

@borkmann borkmann borkmann approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bmcustodio @pchaigno @gandro @borkmann @aanm @qmonnet @joestringer