daemon: Rename host-reachable services to socket LB #20369

brb · 2022-07-01T10:04:38Z

Probably our worst-named feature 😞

Rename "host-reachable services" to "socket LB". The "host-reachable services" terminology will be completely removed in v1.13.

borkmann · 2022-07-01T13:55:31Z

daemon/cmd/daemon_main.go

@@ -365,8 +365,13 @@ func initializeFlags() {
 	flags.Bool(option.BPFSocketLBHostnsOnly, false, "Skip socket LB for services when inside a pod namespace, in favor of service LB at the pod interface. Socket LB is still used when in the host namespace. Required by service mesh (e.g., Istio, Linkerd).")
 	option.BindEnv(option.BPFSocketLBHostnsOnly)

+	flags.Bool(option.EnableSocketLB, false, "Enable socket-based LB for E/W traffic")
+	option.BindEnv(option.EnableSocketLB)


But why even add a new one? Can't we just hide/deprecate the existing one and then fold everything implicitly behind the KPR setting to simplify the user experience?

My reasoning is that folks might still want to opt out from the socket LB. Removing the flag would make it impossible.

Considering we now have --bpf-lb-sock-hostns-only what would be the use case for disabling socket-level LB? Also, if we deprecate it, we give one release for users to tell us that they are actually using it.

(I don't have a strong opinion on this, but generally in favor of reducing the number of datapath options.)

There are still some rough edges with the socket LB (e.g., the stale backend for connected UDP).

brb · 2022-07-01T15:37:09Z

/test

brb · 2022-07-04T10:05:20Z

/test-1.24-net-next

brb · 2022-07-06T10:35:33Z

/test-1.24-net-next

brb · 2022-07-06T15:25:14Z

/test

Job 'Cilium-PR-K8s-GKE' failed:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: Timed out after 61.529s.

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create one.

brb · 2022-07-13T11:07:19Z

/test-gke

brb · 2022-07-13T13:45:19Z

/test-gke

brb · 2022-07-13T14:13:08Z

test-gke is broken. Got ACKs from majority. Marking ready to merge.

Note: This commit was first submitted via #20244 and merged to a feature branch. This new version of the commit is similar, but rebased on the master branch, and addresses the conflicts with the following PRs: - #19379 (File requirements-aks.rst split into two files) - #20369 (File host-services.rst removed) - #19760 (New files under gettingstarted/servicemesh) - #20228 (New files under gettingstarted/clustermesh) - #20439 (New files under gettingstarted/clustermesh) - #20428 (New refs to update in troubleshooting_servicemesh.rst) - #20260 (One ref moved to troubleshooting_clustermesh.rst) This commit also updates CODEOWNERS to reflect the updated paths. This is part of a reorganisation of Cilium's docs (GSoD project). Signed-off-by: Yoyo Wu <yoyo19980720@126.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>

Note: This commit was first submitted via #20244 and merged to a feature branch. This new version of the commit is similar, but rebased on the master branch, and addresses the conflicts with the following PRs: - #19379 (File requirements-aks.rst split into two files) - #20369 (File host-services.rst removed) - #19760 (New files under gettingstarted/servicemesh) - #20228 (New files under gettingstarted/clustermesh) - #20439 (New files under gettingstarted/clustermesh) - #20428 (New refs to update in troubleshooting_servicemesh.rst) - #20260 (One ref moved to troubleshooting_clustermesh.rst) This commit also updates CODEOWNERS to reflect the updated paths, and fixed a minor issue from the feature branch [0]. [0] #20681 (comment) This is part of a reorganisation of Cilium's docs (GSoD project). Signed-off-by: Yoyo Wu <yoyo19980720@126.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>

Note: This commit was first submitted via cilium#20244 and merged to a feature branch. This new version of the commit is similar, but rebased on the master branch, and addresses the conflicts with the following PRs: - cilium#19379 (File requirements-aks.rst split into two files) - cilium#20369 (File host-services.rst removed) - cilium#19760 (New files under gettingstarted/servicemesh) - cilium#20228 (New files under gettingstarted/clustermesh) - cilium#20439 (New files under gettingstarted/clustermesh) - cilium#20428 (New refs to update in troubleshooting_servicemesh.rst) - cilium#20260 (One ref moved to troubleshooting_clustermesh.rst) This commit also updates CODEOWNERS to reflect the updated paths, and fixed a minor issue from the feature branch [0]. [0] cilium#20681 (comment) This is part of a reorganisation of Cilium's docs (GSoD project). Signed-off-by: Yoyo Wu <yoyo19980720@126.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>

The terminology and friends were deprecated in v1.12, and they will be removed in v1.13: cilium/cilium#20369. Use "Socket LB" everywhere instead. Signed-off-by: Martynas Pumputis <m@lambda.lt>

The terminology and friends were deprecated in v1.12, and they will be removed in v1.13: cilium#20369. Use "Socket LB" everywhere instead. Signed-off-by: Martynas Pumputis <m@lambda.lt>

@martynas

This commit applies a Cilium configuration based on 3 issues: [Services are inaccessible from KubeVirt VMs when using kube-proxy free configuration · Issue #14563 · cilium/cilium] (cilium/cilium#14563) > # Services are inaccessible from KubeVirt VMs when using kube-proxy free > configuration #14563 Kubevirt has a layered networking stack that is > described > [here](https://github.com/kubevirt/kubevirt/blob/master/docs/devel/networking.md). As > Daniel Borkman kindly described > [here](https://cilium.slack.com/archives/C1MATJ5U5/p1610058107366400?thread_ts=1609804735.250100&cid=C1MATJ5U5), > "the east-west based load-balancing is basically realised through BPF > attaching to socket hooks e.g. connect(2) and then doing the service xlation > once at connect time from there. This means there is no packet-based NAT > involved. To get this to work, we'd need to compile in the old-style service > translation in bpf\_lxc to catch untranslated service requests on a > per-packet basis (cc [@martynas](https://github.com/martynas)). This would > get ClusterIP translation working for kubevirt case containers at least (and > therefore resolve your DNS issues)." [datapath: Add a new option to skip socket lb when in pod ns by brb · Pull Request #17154 · cilium/cilium] (cilium/cilium#17154) > Diff from previous PR (cannot push to the fork's branch, so opening a new PR instead): > > - Explicitly enable bpf\_lxc LB if the bypass is enabled (previously, the > ifdef was not checking whether the bypass macro was defined). > - Rename the bypass macro to `ENABLE_SOCKET_LB_HOST_ONLY`. > - Rename the helm var from `loadBalancer.hostNamespaceOnly` to > `hostServices.hostNamespaceOnly`. > - Minor doc improvements. [daemon: Rename host-reachable services to socket LB by brb · Pull Request #20369 · cilium/cilium] (cilium/cilium#20369) > Rename "host-reachable services" to "socket LB". The "host-reachable > services" terminology will be completely removed in v1.13.

brb added the needs-backport/1.12 label Jul 1, 2022

maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2022

brb added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 1, 2022

brb force-pushed the pr/brb/rename-hrs branch from 1e8fd71 to e88db14 Compare July 1, 2022 12:39

maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2022

brb mentioned this pull request Jul 1, 2022

datapath: Get rid of host-reachable svc protos and rename host reachable-svc to socket-lb #17241

Closed

brb force-pushed the pr/brb/rename-hrs branch 2 times, most recently from b181ca8 to 0028485 Compare July 1, 2022 13:52

borkmann reviewed Jul 1, 2022

View reviewed changes

brb force-pushed the pr/brb/rename-hrs branch 2 times, most recently from e949d58 to 9948cce Compare July 4, 2022 09:56

brb force-pushed the pr/brb/rename-hrs branch from 9948cce to 5232008 Compare July 6, 2022 09:41

brb marked this pull request as ready for review July 6, 2022 17:18

brb requested a review from a team July 6, 2022 17:18

brb requested a review from a team as a code owner July 6, 2022 17:18

brb requested a review from a team July 6, 2022 17:18

brb requested review from a team as code owners July 6, 2022 17:18

brb requested a review from a team July 6, 2022 17:18

brb requested review from a team as code owners July 6, 2022 17:18

brb requested a review from a team July 6, 2022 17:18

brb requested a review from a team as a code owner July 6, 2022 17:18

brb requested review from borkmann and tklauser July 6, 2022 17:18

borkmann approved these changes Jul 13, 2022

View reviewed changes

brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 13, 2022

ldelossa merged commit d55bfa5 into master Jul 14, 2022

ldelossa deleted the pr/brb/rename-hrs branch July 14, 2022 12:14

This was referenced Jul 14, 2022

docs: Deprecate host-reachable services page #14326

Closed

datapath: Rename KPR and friends #17484

Closed

ldelossa mentioned this pull request Jul 15, 2022

v1.12 backports 2022-07-14 #20534

Merged

ldelossa added backport-pending/1.12 and removed needs-backport/1.12 labels Jul 15, 2022

maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 15, 2022

aanm added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jul 18, 2022

qmonnet mentioned this pull request Jul 28, 2022

[feature branch merge] docs: restructure Getting Started section #20681

Merged

brb mentioned this pull request Aug 10, 2022

connectivity: Get rid of host reachable svc cilium/cilium-cli#1029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

daemon: Rename host-reachable services to socket LB #20369

daemon: Rename host-reachable services to socket LB #20369

Uh oh!

brb commented Jul 1, 2022 •

edited

Loading

Uh oh!

borkmann Jul 1, 2022 •

edited

Loading

Uh oh!

brb Jul 1, 2022

Uh oh!

pchaigno Jul 1, 2022

Uh oh!

brb Jul 1, 2022

Uh oh!

brb commented Jul 1, 2022

Uh oh!

brb commented Jul 4, 2022

Uh oh!

brb commented Jul 6, 2022

Uh oh!

brb commented Jul 6, 2022 •

edited by maintainer-s-little-helper bot

Loading

Test Name

Failure Output

Uh oh!

brb commented Jul 13, 2022

Uh oh!

brb commented Jul 13, 2022

Uh oh!

brb commented Jul 13, 2022

Uh oh!

Uh oh!

daemon: Rename host-reachable services to socket LB #20369

daemon: Rename host-reachable services to socket LB #20369

Uh oh!

Conversation

brb commented Jul 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

borkmann Jul 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brb Jul 1, 2022

Choose a reason for hiding this comment

Uh oh!

pchaigno Jul 1, 2022

Choose a reason for hiding this comment

Uh oh!

brb Jul 1, 2022

Choose a reason for hiding this comment

Uh oh!

brb commented Jul 1, 2022

Uh oh!

brb commented Jul 4, 2022

Uh oh!

brb commented Jul 6, 2022

Uh oh!

brb commented Jul 6, 2022 • edited by maintainer-s-little-helper bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Name

Failure Output

Uh oh!

brb commented Jul 13, 2022

Uh oh!

brb commented Jul 13, 2022

Uh oh!

brb commented Jul 13, 2022

Uh oh!

Uh oh!

brb commented Jul 1, 2022 •

edited

Loading

borkmann Jul 1, 2022 •

edited

Loading

brb commented Jul 6, 2022 •

edited by maintainer-s-little-helper bot

Loading