Skip to content

Conversation

gandro
Copy link
Member

@gandro gandro commented May 30, 2022

This commit adds the -o json output to cilium node list and
cilium-health status, as the text version of both does not contain all
details.

This commit adds the `-o json` output to `cilium node list` and
`cilium-health status`, as the text version of both does not contain all
details.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added area/bugtool Impacts gathering of data for debugging purposes. release-note/misc This PR makes changes that have no direct user impact. labels May 30, 2022
@gandro gandro requested a review from a team as a code owner May 30, 2022 16:31
@gandro gandro requested a review from ldelossa May 30, 2022 16:31
@gandro
Copy link
Member Author

gandro commented May 31, 2022

/test

@gandro
Copy link
Member Author

gandro commented Jun 1, 2022

CI is green. This is pending review.

Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2022
@joestringer joestringer merged commit c6af580 into cilium:master Jun 3, 2022
@joestringer
Copy link
Member

@gandro should we backport this to 1.10/1.11? It's trivial and could help debugging existing environments.

@gandro
Copy link
Member Author

gandro commented Jun 7, 2022

@gandro should we backport this to 1.10/1.11? It's trivial and could help debugging existing environments.

Oh, good call! Yes, let's do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bugtool Impacts gathering of data for debugging purposes. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants