Skip to content

docs: add kube-apiserver to the special identity list #20047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

docs: add kube-apiserver to the special identity list #20047

merged 1 commit into from
Jun 2, 2022

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Jun 1, 2022 •
edited
Loading

Both were not added into the documentation, description taken from their constant godoc comment string.

@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 1, 2022
@kaworu kaworu requested a review from a team as a code owner June 1, 2022 17:14
@kaworu kaworu requested a review from qmonnet June 1, 2022 17:14
rolinh
rolinh reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Should we also update the well known identities below as it is also missing some entries?

joestringer
joestringer approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this should be two patches - update for kube-apiserver (and backport to 1.11), then ingress (only for master for upcoming 1.12 release)

@kaworu kaworu force-pushed the pr/kaworu/doc/add-missing-reserved-identities branch from 9a2ff7f to 4ea637e Compare June 2, 2022 15:48
@kaworu kaworu changed the title docs: add kube-apiserver and ingress to the special identity list docs: add kube-apiserver to the special identity list Jun 2, 2022
@kaworu
docs: add kube-apiserver to the special identity list
4ea637e 
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu mentioned this pull request Jun 2, 2022
Merged
@kaworu
Copy link
Member Author

kaworu commented Jun 2, 2022

@joestringer make sense! I've dropped ingress from this PR and marked it for v1.11 backport, ingress PR is at #20060.

@joestringer joestringer merged commit 9580ea3 into cilium:master Jun 2, 2022
@kaworu kaworu deleted the pr/kaworu/doc/add-missing-reserved-identities branch June 3, 2022 09:16
@joamaki joamaki mentioned this pull request Jun 8, 2022
Merged
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 9, 2022
@joestringer joestringer mentioned this pull request Jun 13, 2022
Merged
@aanm aanm mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh left review comments

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaworu @joestringer @rolinh @qmonnet @joamaki