ctmap,daemon: Exclude host IPs from conntrack GC during startup #19998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zuzzas
reviewed
May 30, 2022
66583b7 to
721ef47
Compare
|
@pchaigno |
YutaroHayakawa
approved these changes
May 31, 2022
721ef47 to
1841658
Compare
ldelossa
reviewed
Jun 2, 2022
| @@ -30,7 +31,8 @@ type EndpointManager interface { | |||
| } | |||
|
|
|||
| // Enable enables the connection tracking garbage collection. | |||
| func Enable(ipv4, ipv6 bool, restoredEndpoints []*endpoint.Endpoint, mgr EndpointManager) { | |||
| func Enable(ipv4, ipv6 bool, restoredEndpoints []*endpoint.Endpoint, mgr EndpointManager, | |||
| nodeAddressing types.NodeAddressing) { | |||
There was a problem hiding this comment.
A bit of a nit but it would be nice to comment or document which of these arguments are used for GC filtering.
ldelossa
approved these changes
Jun 2, 2022
When the host firewall is enabled, we start tracking (and potentially enforcing policies) on all connections to and from the host IP addresses. Thus, we also need to avoid GCing the host IPs. If we don't it can cause established connections to be broken on agent restart. Reported-by: Andrey Klimentyev <andrey.klimentyev@flant.com> Reported-by: Jarno Rajahalme <jarno@isovalent.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
1841658 to
722cf3e
Compare
|
/test |
|
🤔 I'm confused, how do we garbage collect host IPs now? Won't this just lead to the CT table being full of expired entries corresponding to host connections? |
|
@joestringer We only skip host IPs for the initial scan ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host firewall is enabled, we start tracking (and potentially enforcing policies) on all connections to and from the host IP addresses. Thus, we also need to avoid GCing the host IPs. If we don't it can cause established connections to be broken on agent restart.
Fixes: #19367.