-
Notifications
You must be signed in to change notification settings - Fork 3.4k
metrics: Fix NaN value for cilium metrics list CLI #19987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit is to bump prometheus client library to the latest (e.g. v1.12.2) which will have a better support for go collector of different go versions, and fix NaN value. Fixes: cilium#19985 Signed-off-by: Tam Mach <tam.mach@cilium.io>
The underlying issue was fixed as part of client_go v1.12.2. Signed-off-by: Tam Mach <tam.mach@cilium.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast! 🚀
Is this affecting or going to affect any stable release? That is, do we need to backport? |
Just do a quick test to confirm as per below 1.11.4
1.11.5
|
/test |
GKE CI failures are tracked under #20013. The changes in this PR are verified as part of conformance tests, also local testing. Marking this ready to merge, please let me know if you think otherwise. |
And the AWS-CNI workflow will be fixed by #19994. EDIT: Nah, not volunteering for this anymore. |
Description
Please refer to commit details
Testing
Testing was done locally before and after changes. From the changes in vendor,
gc_cpu_fraction
metric was having NaN value.Before
After