-
Notifications
You must be signed in to change notification settings - Fork 3.4k
clustermesh: Add ownerReferences for CiliumNodes #19959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
All tests are passed, force pushed with below diff diff --git a/clustermesh-apiserver/vmmanager.go b/clustermesh-apiserver/vmmanager.go
index 8a42d113b6..648afffaca 100644
--- a/clustermesh-apiserver/vmmanager.go
+++ b/clustermesh-apiserver/vmmanager.go
@@ -279,7 +279,7 @@ func (m *VMManager) UpdateCiliumNodeResource(n *nodeTypes.RegisterNode, cew *cil
nr.OwnerReferences = []metav1.OwnerReference{
{
APIVersion: ciliumv2.SchemeGroupVersion.String(),
- Kind: "CiliumExternalWorkload",
+ Kind: ciliumv2.CEWKindDefinition,
Name: cew.GetName(),
UID: cew.GetUID(),
}, |
/test |
jrajahalme
approved these changes
Jun 2, 2022
This commit is to add ownerReferences for CiliumNodes created by CiliumExternalWorkload, so that we don't unintentionally GC invalid CN. Thanks to @nathanejohnson for reporting this issue. Fixes: cilium#19907 Signed-off-by: Tam Mach <tam.mach@cilium.io>
rebased with master to pick up latest CI changes. |
/test |
/test-runtime |
AWS-CNI failure is currently under investigation or already fixed as part of master #20049. Reviews are in, marking this ready to merge. |
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to add ownerReferences for CiliumNodes created by
CiliumExternalWorkload, so that we don't unintentionally GC invalid CN.
Thanks to @nathanejohnson for reporting this issue.
Fixes: #19907
Signed-off-by: Tam Mach tam.mach@cilium.io