Skip to content

Conversation

brb
Copy link
Member

@brb brb commented May 16, 2022

The PR [1] added "-Wimplicit-int-conversion" which broke
____revalidate_data_pull(). The latter is used when attaching bpf_host
to a L3 netdev.

[1]: #18501

The PR [1] added "-Wimplicit-int-conversion" which broke
____revalidate_data_pull(). The latter is used when attaching bpf_host
to a L3 netdev.

[1]: #18501

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.11 labels May 16, 2022
@brb brb requested review from a team and YutaroHayakawa May 16, 2022 12:39
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tklauser tklauser removed the request for review from YutaroHayakawa May 18, 2022 09:23
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 23, 2022
@jibi jibi merged commit 20f315d into master May 23, 2022
@jibi jibi deleted the pr/brb/fix-l3-dev-conv branch May 23, 2022 12:26
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants