api: don't attempt to set unix domain socket group to cilium
#19850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
rolinh
approved these changes
May 17, 2022
tommyp1ckles
approved these changes
May 17, 2022
michi-covalent
approved these changes
May 17, 2022
joestringer
approved these changes
May 17, 2022
cf34ac3 to
e0dfa97
Compare
|
Added a second commit to drop the |
e0dfa97 to
a7e4e65
Compare
|
/test-runtime |
a7e4e65 to
4985707
Compare
|
/test-runtime |
4985707 to
dd6b11b
Compare
Since commit 67f74ff ("images/cilium: remove cilium group from Dockerfile") the cilium group is no longer created in the image running the agent, resulting in the following log message on cilium-agent start: level=info msg="Group not found" error="group: unknown group cilium" file-path=/var/run/cilium/cilium.sock group=cilium subsys=api Setting the group is no longer necessary, so drop that part of SetDefaultPermissions. Signed-off-by: Tobias Klauser <tobias@cilium.io>
dd6b11b to
174803b
Compare
|
/test-runtime |
ac4c6df to
95720a2
Compare
|
/test-runtime |
95720a2 to
5cd6198
Compare
|
/test-runtime |
Since commit 67f74ff ("images/cilium: remove cilium group from Dockerfile") the cilium group is no longer created in the docker image. Follow the same approach for the agent running in the test/dev VM. As a consequence, the per-node `cilium` command needs to be run as `root` in the runtime tests. Signed-off-by: Tobias Klauser <tobias@cilium.io>
5cd6198 to
3460d4c
Compare
|
/test-runtime |
christarazi
approved these changes
May 18, 2022
|
/test |
|
Closing in favor of #19927. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 67f74ff ("images/cilium: remove cilium group from
Dockerfile") the cilium group is no longer created in the image running
the agent, resulting in the following log message on cilium-agent start:
Setting the group is no longer necessary, so that part of
SetDefaultPermissions.