Skip to content

cli: Update regex for key value validation #19794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022

Conversation

sayboras
Copy link
Member

This commit is to allow empty value, as well as @ character in value for
key value pair validation.

Fixes: #19793
Signed-off-by: Tam Mach tam.mach@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 12, 2022
@sayboras sayboras added the release-note/bug This PR fixes an issue in a previous release of Cilium. label May 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 12, 2022
This commit is to allow empty value, as well as @ character in value for
key value pair validation.

Fixes: cilium#19793
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/map-string-regex branch from bad93e8 to ccc1225 Compare May 12, 2022 02:25
@sayboras sayboras marked this pull request as ready for review May 12, 2022 11:13
@sayboras sayboras requested a review from a team as a code owner May 12, 2022 11:13
@christarazi
Copy link
Member

/test

@sayboras
Copy link
Member Author

/test-runtime

@sayboras
Copy link
Member Author

I am marking this ready to merge as:

  • ci-external-workloads failure will be fixed as part of gha: Bump cilum cli version to v0.11.6 #19828
  • conformance aks failure is known issue (which will be addressed separately),
  • travis ci failure due to retry limit
  • all other jobs are successfully ran
  • required reviews are in.

Automatic restarts limited: Please try restarting this job later or contact support@travis-ci.com.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2022
@christarazi christarazi merged commit eaa7141 into cilium:master May 16, 2022
@jibi jibi added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels May 23, 2022
@sayboras sayboras deleted the tam/map-string-regex branch June 17, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium operator unable to process empty tags or tags with an @ symbol or tags with spaces
3 participants