Skip to content

helm: don't generate the hubble-peer svc during preflight checks #19759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

helm: don't generate the hubble-peer svc during preflight checks #19759

merged 1 commit into from
May 10, 2022

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented May 10, 2022

Before this patch, the hubble-peer Service would be deployed during preflight check, which will in turn prevent Cilium to be installed as it would attempt to install it again.

Hit by #19750 (CI build link):

00:45:35.626  	 Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: Service "hubble-peer" in namespace "kube-system" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "cilium-preflight": current value is "cilium"

@kaworu kaworu added kind/bug This is a bug in the Cilium logic. sig/hubble area/helm Impacts helm charts and user deployment experience labels May 10, 2022
@kaworu kaworu requested review from gandro and a team May 10, 2022 09:38
@kaworu kaworu requested a review from a team as a code owner May 10, 2022 09:38
@kaworu kaworu requested review from a team and sayboras May 10, 2022 09:38
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 10, 2022
@kaworu kaworu added the release-note/misc This PR makes changes that have no direct user impact. label May 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2022
@kaworu
helm: don't generate the hubble-peer svc during preflight checks
ae671f2 
Before this patch, the hubble-peer Service would be deployed during
preflight check, which will in turn prevent Cilium to be installed as it
would attempt to install it again.

Suggested-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
@kaworu kaworu requested review from nathanjsweet and removed request for sayboras May 10, 2022 09:39
gandro
gandro approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaworu
Copy link
Member Author

kaworu commented May 10, 2022

/test

@gandro
Copy link
Member

gandro commented May 10, 2022

This seems to have passed relevant Jenkins pipelines. All other failures are unrelated to Helm. Let's merge it to fix CI.

@gandro gandro merged commit 35f2ff3 into cilium:master May 10, 2022
@kaworu kaworu deleted the pr/kaworu/no-peer-service-on-preflight-checks branch May 11, 2022 12:56
@pchaigno pchaigno mentioned this pull request May 12, 2022
Merged
6 tasks
This was referenced May 17, 2022
Merged
Merged
@jibi jibi added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels May 23, 2022
This was referenced Jun 10, 2022
Merged
Merged
@aanm aanm mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaworu @gandro @nathanjsweet @jibi @christarazi