Skip to content

Add cilium cli to aws cni conformance tests #19555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

Add cilium cli to aws cni conformance tests #19555

merged 1 commit into from
Apr 28, 2022

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 25, 2022

Waiting on cilium/cilium-cli#807 to be merged and a cilium-cli version released

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Apr 25, 2022
@aanm aanm requested review from a team as code owners April 25, 2022 13:02
@aanm aanm requested review from joestringer and nbusseneau April 25, 2022 13:02
@aanm aanm marked this pull request as draft April 25, 2022 13:02
@aanm aanm added the dont-merge/waiting-for-upstream Only merge once upstream library or kernel features have landed label Apr 25, 2022
@joestringer joestringer mentioned this pull request Apr 27, 2022
Merged
@aanm aanm force-pushed the pr/add-cilium-cli-aws-cni branch 2 times, most recently from 70eecfe to b5cf137 Compare April 27, 2022 22:36
@joestringer joestringer mentioned this pull request Apr 28, 2022
Merged
@aanm aanm force-pushed the pr/add-cilium-cli-aws-cni branch from b5cf137 to 642284c Compare April 28, 2022 02:47
@aanm
.github: add support for cilium-cli in aws-cni conformance tests
892b85b 
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/add-cilium-cli-aws-cni branch from 642284c to 892b85b Compare April 28, 2022 10:55
@aanm
Copy link
Member Author

aanm commented Apr 28, 2022

The aws-cni test passed with the test commit.

@aanm aanm marked this pull request as ready for review April 28, 2022 10:56
@aanm aanm removed the dont-merge/waiting-for-upstream Only merge once upstream library or kernel features have landed label Apr 28, 2022
@aanm aanm merged commit 2d7af3a into master Apr 28, 2022
@aanm aanm deleted the pr/add-cilium-cli-aws-cni branch April 28, 2022 20:28
@pchaigno pchaigno mentioned this pull request May 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@joestringer joestringer Awaiting requested review from joestringer joestringer was automatically assigned from cilium/github-sec

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau was automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanm @sayboras @michi-covalent