Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 22, 2022

Signed-off-by: André Martins andre@cilium.io

Add support for Kubernetes v1.24.0

Note for reviewers: This PR was tested against kernel 4.9 and k8s 1.24. The tests that are currently failing are known as they are also failing for other Kubernetes versions and thus not being k8s specific. Since it's currently not possible to update the net-next VM I'm proposing to change running the net-next w/ k8s 1.24 to running kernel 4.9 with k8s 1.24.

@aanm aanm added release-note/major This PR introduces major new functionality to Cilium. release-blocker/1.12 labels Apr 22, 2022
@aanm
Copy link
Member Author

aanm commented Apr 22, 2022

/test

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 500a7d1 to 4d2bf78 Compare April 22, 2022 23:28
@aanm
Copy link
Member Author

aanm commented Apr 22, 2022

/test

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 4d2bf78 to c6a58dc Compare April 25, 2022 13:41
@aanm
Copy link
Member Author

aanm commented Apr 25, 2022

/test-vagrant

@aanm
Copy link
Member Author

aanm commented Apr 25, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from c6a58dc to 3fa1aff Compare April 27, 2022 12:57
@aanm
Copy link
Member Author

aanm commented Apr 27, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 3fa1aff to 3de7a85 Compare April 27, 2022 21:44
@aanm
Copy link
Member Author

aanm commented Apr 27, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 3de7a85 to cde4591 Compare April 27, 2022 21:45
@aanm
Copy link
Member Author

aanm commented Apr 27, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from cde4591 to 2fc6231 Compare April 27, 2022 22:09
@aanm
Copy link
Member Author

aanm commented Apr 27, 2022

/test-1.24-net-next

@aanm aanm changed the title Update k8s tests and libraries to v1.24.0-rc.0 Update k8s tests and libraries to v1.24.0-rc.1 Apr 27, 2022
@aanm aanm force-pushed the pr/bump-k8s-versions branch from 2fc6231 to 21ada00 Compare April 27, 2022 22:34
@aanm
Copy link
Member Author

aanm commented Apr 27, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 21ada00 to 8fc6d9b Compare April 27, 2022 22:49
@aanm
Copy link
Member Author

aanm commented Apr 27, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 8fc6d9b to ffdeea7 Compare April 29, 2022 22:32
@aanm
Copy link
Member Author

aanm commented Apr 29, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from ffdeea7 to 5bf5ac0 Compare April 29, 2022 23:00
@aanm
Copy link
Member Author

aanm commented Apr 29, 2022

/test-1.24-net-next

1 similar comment
@aanm
Copy link
Member Author

aanm commented Apr 29, 2022

/test-1.24-net-next

@aanm aanm force-pushed the pr/bump-k8s-versions branch from 5bf5ac0 to 3c28111 Compare April 30, 2022 00:21
@aanm
Copy link
Member Author

aanm commented Apr 30, 2022

/test

@aanm
Copy link
Member Author

aanm commented Apr 30, 2022

/test-upstream-k8s

@aanm
Copy link
Member Author

aanm commented May 19, 2022

/test-upstream

aanm added 3 commits May 19, 2022 15:30
This VM contains the containerd container rumtime that is going to be
used with Kubernetes 1.24 as Kubernetes dropped support for docker.

Switched the container runtime to containerd since that is already
available in K8s 1.23 and we can start using it this version. If we keep
docker, the container images will have to be pulled by the docker container
runtime making the tests slower and eventually timeout.

Fixed the pre-pull of docker images while provisioing the VM

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
These tests are currently failing for other Kubernetes versions and they
are now failing for these versions. Thus, we should quarantine them to
unblock the CI.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/bump-k8s-versions branch from b4ff997 to 0e542df Compare May 19, 2022 13:30
@aanm aanm requested a review from a team May 19, 2022 13:30
@aanm
Copy link
Member Author

aanm commented May 19, 2022

/test-1.24-4.9

@aanm aanm removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels May 19, 2022
@aanm
Copy link
Member Author

aanm commented May 19, 2022

The previous test failed with #17270

@aanm
Copy link
Member Author

aanm commented May 19, 2022

/test-1.24-4.19

@aanm aanm merged commit 282a729 into cilium:master May 19, 2022
@aanm aanm deleted the pr/bump-k8s-versions branch May 19, 2022 19:13
Shunpoco added a commit to Shunpoco/cilium that referenced this pull request Oct 31, 2022
We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in cilium#19545.

Fixes: cilium#21935

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
aanm pushed a commit that referenced this pull request Nov 2, 2022
We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in #19545.

Fixes: #21935

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
michi-covalent pushed a commit that referenced this pull request Nov 15, 2022
[ upstream commit 9f37627 ]

We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in #19545.

Fixes: #21935

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
michi-covalent pushed a commit to pchaigno/cilium that referenced this pull request Nov 16, 2022
[ upstream commit 9f37627 ]

We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in cilium#19545.

Fixes: cilium#21935

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
michi-covalent pushed a commit that referenced this pull request Nov 16, 2022
[ upstream commit 9f37627 ]

We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in #19545.

Fixes: #21935

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/major This PR introduces major new functionality to Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants