-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update k8s tests and libraries to v1.24.0 #19545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
500a7d1
to
4d2bf78
Compare
/test |
4d2bf78
to
c6a58dc
Compare
/test-vagrant |
/test-1.24-net-next |
c6a58dc
to
3fa1aff
Compare
/test-1.24-net-next |
3fa1aff
to
3de7a85
Compare
/test-1.24-net-next |
3de7a85
to
cde4591
Compare
/test-1.24-net-next |
cde4591
to
2fc6231
Compare
/test-1.24-net-next |
2fc6231
to
21ada00
Compare
/test-1.24-net-next |
21ada00
to
8fc6d9b
Compare
/test-1.24-net-next |
8fc6d9b
to
ffdeea7
Compare
/test-1.24-net-next |
ffdeea7
to
5bf5ac0
Compare
/test-1.24-net-next |
1 similar comment
/test-1.24-net-next |
5bf5ac0
to
3c28111
Compare
/test |
/test-upstream-k8s |
/test-upstream |
This VM contains the containerd container rumtime that is going to be used with Kubernetes 1.24 as Kubernetes dropped support for docker. Switched the container runtime to containerd since that is already available in K8s 1.23 and we can start using it this version. If we keep docker, the container images will have to be pulled by the docker container runtime making the tests slower and eventually timeout. Fixed the pre-pull of docker images while provisioing the VM Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
These tests are currently failing for other Kubernetes versions and they are now failing for these versions. Thus, we should quarantine them to unblock the CI. Signed-off-by: André Martins <andre@cilium.io>
b4ff997
to
0e542df
Compare
/test-1.24-4.9 |
The previous test failed with #17270 |
/test-1.24-4.19 |
7 tasks
Shunpoco
added a commit
to Shunpoco/cilium
that referenced
this pull request
Oct 31, 2022
We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in cilium#19545. Fixes: cilium#21935 Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
michi-covalent
pushed a commit
that referenced
this pull request
Nov 15, 2022
[ upstream commit 9f37627 ] We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in #19545. Fixes: #21935 Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
michi-covalent
pushed a commit
to pchaigno/cilium
that referenced
this pull request
Nov 16, 2022
[ upstream commit 9f37627 ] We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in cilium#19545. Fixes: cilium#21935 Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
michi-covalent
pushed a commit
that referenced
this pull request
Nov 16, 2022
[ upstream commit 9f37627 ] We can't use `RUNTIME=docker` option any longer because since v1.24.0, kubernetes doesn't support docker as a container runtime and herlpers.bash was already modified to use containerd or cri-o in #19545. Fixes: #21935 Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Martins andre@cilium.io
Note for reviewers: This PR was tested against kernel 4.9 and k8s 1.24. The tests that are currently failing are known as they are also failing for other Kubernetes versions and thus not being k8s specific. Since it's currently not possible to update the net-next VM I'm proposing to change running the net-next w/ k8s 1.24 to running kernel 4.9 with k8s 1.24.