test/bpf: Fix mock dependencies #19099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running make with parallel builds, it was previously possible to trigger build of the mocks at the same time as building the test that depended on the mocks. This would cause build failures. Fix this issue by moving the dependencies into dedicated targets with proper dependencies. While we're at it, move the clean target into the proper bpf/mock/Makefile. Signed-off-by: Joe Stringer <joe@cilium.io>
brb
approved these changes
Mar 10, 2022
|
These tests are currently triggered from the integration-tests target, so they will run on Travis. |
|
Build works, Travis runs this target as well and I tested it locally. Reviews are in, should be good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running make with parallel builds, it was previously possible to
trigger build of the mocks at the same time as building the test that
depended on the mocks. This would cause build failures.
Fix this issue by moving the dependencies into dedicated targets with
proper dependencies. While we're at it, move the clean target into the
proper bpf/mock/Makefile.
Fixes: #19098