Use direct routing device only when tunneling is disabled and BPF Host Routing or NodePort are enabled. #18815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a518f53 to
5612531
Compare
|
/test |
5612531 to
7b7b33d
Compare
|
/test |
ldelossa
approved these changes
Feb 16, 2022
pchaigno
approved these changes
Feb 17, 2022
The Direct Routing Device is currently used by BPF Host Routing and BPF Node Port. With both features, we don't need it for tunneling mode. The DirectRoutingDeviceRequired helper function checks the above conditions and returns if the Direct Routing Device is required for the given configuration. Upcoming commits will fix several places that use Direct Routing Device without tunneling or BPF Host Routing in an account using DirectRoutingDeviceRequired. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
26ac911 to
8034fd5
Compare
|
/test Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/test-1.23-net-next |
|
Travis CI failure seems relevant to my changes. Let me check. |
|
I shouldn't skip Actually, in the case of the IPv6, we are handling the missing case here. https://github.com/cilium/cilium/blob/8034fd57180a7ebc8284a9b099d17db7404e45c9/pkg/node/address.go#L113 I'll revert this change. |
Currently, the usage of the Direct Routing Device in Cilium has the following problems. 1. It only checks whether NodePort is enabled when it uses Direct Routing Device. We should also check if the BPF Host Routing and Native Routing are enabled (= tunneling is disabled) or not. 2. It uses the option.Config.DirectRoutingDevice without checking if it is empty. It would be safer to always use it with a check and return errors when it is required but empty. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Some of the tests using default tunneling mode to test Direct Routing Device related features like neighbor discovery or device detection. Due to the fix in the previous commit, now Direct Routing Device is only used when the tunneling is disabled. Thus, those tests will fail. Fix them to use native routing mode explicitly. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
8034fd5 to
88da2ee
Compare
|
/test |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit for details.
Fixes: #17480