Skip to content

Ensure priority scheduling #18667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

Ensure priority scheduling #18667

merged 1 commit into from
Feb 25, 2022

Conversation

sdake
Copy link
Contributor

@sdake sdake commented Jan 30, 2022 •
edited by aanm
Loading

An annotation, deprecated in Kubernetes 1.16 and no longer functional,
was used to ensure priority scheduling. Use priorityClassName to achieve
same result.

Signed-off-by: Steven Dake steven.dake@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

Ensure priority scheduling of CNI agent. Repair a deprecated Kubernetes annotation. The annotation was used to schedule pods at high priority. This deprecation, which occurred in Kubernetes 1.16, results in unexpected behavior.

@sdake sdake requested a review from a team as a code owner January 30, 2022 21:56
@sdake sdake requested review from a team, gandro and sayboras January 30, 2022 21:56
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 30, 2022
@sayboras sayboras added area/helm Impacts helm charts and user deployment experience release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 30, 2022
sayboras
sayboras reviewed Jan 30, 2022
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, I have one comment as per below, let me know if it's making sense.

@sdake sdake requested a review from a team as a code owner January 31, 2022 07:07
@sdake sdake requested a review from christarazi January 31, 2022 07:07
sayboras
sayboras approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help. LGTM 💯

gandro
gandro reviewed Jan 31, 2022
View reviewed changes
test/k8sT/manifests/log-gatherer.yaml
@@ -19,8 +19,6 @@ spec:
kubernetes.io/cluster-service: "true"
template:
metadata:
annotations:
scheduler.alpha.kubernetes.io/critical-pod: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this commit into the first one. Thanks!

christarazi
christarazi reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Echoing Sebastian's comment, please squash all commits into the first.

@sdake sdake force-pushed the ensure-priority-scheduling branch from 67b27bf to a9cdae9 Compare February 4, 2022 05:23
@sdake
Copy link
Contributor Author

sdake commented Feb 24, 2022

@sayboras @christarazi @gandro,

Hi gang.

This PR needs manual intervention from a maintainer to run the workflow. Would someone be kind enough to ping a maintainer if you yourselves don't have ACLs?

Cheers,
-steve

@sdake sdake force-pushed the ensure-priority-scheduling branch from a9cdae9 to 8ead319 Compare February 24, 2022 07:56
@sdake
Copy link
Contributor Author

sdake commented Feb 24, 2022

Three maintainers were randomly selected to run the workflow as this was my first commit to this GitHub organization. Would someone be kind enough to see: #18667 (comment)

@danwent @lizrice @vadorovsky

Cheers,
-steve

@sdake
Copy link
Contributor Author

sdake commented Feb 24, 2022

Thank you @sayboras I noticed a maintainers file in the repo on a rebase, so I pinged 3 at random.

Cheers,
-steve

@sdake
Ensure priority scheduling
d683f9f 
An annotation, deprecated in Kubernetes 1.16 and no longer functional,
was used to ensure priority scheduling.

Signed-off-by: Steven Dake <steven.dake@gmail.com>
@sdake sdake force-pushed the ensure-priority-scheduling branch from 8ead319 to d683f9f Compare February 24, 2022 08:11
@gandro
Copy link
Member

gandro commented Feb 24, 2022

Thanks for squashing and apologies for the delay. Please let us know via comment when push to a PR to address requested changes, this unfortunately slipped my review queue due to the lack of new comments since you pushed.

Changes approved, I will run the test suite now.

@gandro
Copy link
Member

gandro commented Feb 24, 2022

/test

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 24, 2022
@gandro
Copy link
Member

gandro commented Feb 24, 2022

Marking ready to merge. All tests have passed (L4LB XDP is skipped due to this PR not changing any related code).

@kaworu kaworu merged commit b2e3a25 into cilium:master Feb 25, 2022
@sayboras sayboras mentioned this pull request May 31, 2022
Closed
2 tasks
@sayboras
Copy link
Member

As per this docs, minimum requirement for cilium 1.11 is kube 1.16+, so I think it's safe to back port this PR to 1.11 branch.

Related to #19990

@joamaki joamaki mentioned this pull request Jun 8, 2022
Merged
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 9, 2022
@joestringer joestringer mentioned this pull request Jun 13, 2022
Merged
@ReillyBrogan ReillyBrogan mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

@christarazi christarazi christarazi approved these changes

@sayboras sayboras sayboras approved these changes

Assignees

@gandro gandro

@christarazi christarazi

Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sdake @gandro @sayboras @kaworu @joestringer @christarazi @joamaki