Skip to content

bpf: Fix implicit cast for BPF TPROXY debug message #18429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2022
Merged

bpf: Fix implicit cast for BPF TPROXY debug message #18429

merged 1 commit into from
Jan 10, 2022

Conversation

pchaigno
Copy link
Member

Because dbg_ctx was declared 16-bit long, it would only hold the protocol and not the family (shifted to upper 16 bits). This incorrect implicit cast was discovered thanks to -Wimplicit-int-conversion, which I'm working on enabling.

Fixes: #11279.

@pchaigno
bpf: Fix implicit cast for BPF TPROXY debug message
347658f 
Because dbg_ctx was declared 16-bit long, it would only hold the
protocol and not the family (shifted to upper 16 bits). This incorrect
implicit cast was discovered thanks to -Wimplicit-int-conversion, which
I'm working on enabling.

Fixes: b042aac ("bpf: Implement BPF TPROXY for traffic to the host")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Jan 10, 2022
@pchaigno pchaigno requested review from a team and kkourt January 10, 2022 17:17
@pchaigno pchaigno requested review from joestringer and removed request for kkourt January 10, 2022 17:17
joestringer
joestringer approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joestringer joestringer merged commit 108aa42 into cilium:master Jan 10, 2022
@pchaigno pchaigno deleted the fix-debug-message-value branch January 10, 2022 19:13
@pchaigno pchaigno mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchaigno @joestringer @kkourt