Skip to content

docs: Fix helm value when deploying pure ipvlan l3 mode #17708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2021
Merged

docs: Fix helm value when deploying pure ipvlan l3 mode #17708

merged 1 commit into from
Oct 26, 2021

Conversation

chendotjs
Copy link
Contributor

Suppress warning message from helm:

warning: skipped value for l7Proxy: Not a table.

Signed-off-by: Chen Yaqi chendotjs@gmail.com

@chendotjs
docs: Fix helm value when deploying pure ipvlan l3 mode
96d75c1 
Suppress warning message from helm:

warning: skipped value for l7Proxy: Not a table.

Signed-off-by: Chen Yaqi <chendotjs@gmail.com>
@chendotjs chendotjs requested a review from a team as a code owner October 26, 2021 13:25
@chendotjs chendotjs requested a review from qmonnet October 26, 2021 13:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 26, 2021
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Oct 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 26, 2021
qmonnet
qmonnet approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

Checkpatch error is safe to ignore. It complains about a missing sign-off, but this is simply because the name/email for the commit author are values different than the tag in the commit description. Ready to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 26, 2021
@kkourt kkourt merged commit 7db6998 into cilium:master Oct 26, 2021
This was referenced Oct 28, 2021
Merged
Merged
@joestringer joestringer mentioned this pull request Nov 5, 2021
Merged
@joestringer joestringer mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chendotjs @qmonnet @kkourt @joestringer @nebril