Skip to content

Conversation

glibsm
Copy link
Member

@glibsm glibsm commented Oct 4, 2021

Once this PR is merged, you can update the PR labels via:

$ for pr in 16969 16264 17424 17417 17489; do contrib/backporting/set-labels.py $pr done 1.8; done

or with

$ make add-label branch=v1.8 issues=16969,16264,17424,17417,17489

@glibsm glibsm requested a review from a team as a code owner October 4, 2021 23:28
@glibsm glibsm requested a review from aanm October 4, 2021 23:28
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.8 kind/backports This PR provides functionality previously merged into master. labels Oct 4, 2021
@glibsm
Copy link
Member Author

glibsm commented Oct 5, 2021

/test-backport-1.8

Job 'Cilium-PR-K8s-1.12-kernel-4.9' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sConformance Portmap Chaining Check connectivity-check compliance with portmap chaining

Failure Output

FAIL: connectivity-check pods are not ready after timeout

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.12-kernel-4.9 so I can create a new GitHub issue to track it.

@christarazi
Copy link
Member

@glibsm Looks like test-1.12-4.9 hit #15791

@glibsm glibsm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 6, 2021
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait on #17388 to be merged, then rebase on top.

@kaworu kaworu added dont-merge/blocked Another PR must be merged before this one. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/blocked Another PR must be merged before this one. labels Oct 7, 2021
@errordeveloper
Copy link
Contributor

@glibsm you can rebase now

bluikko and others added 5 commits October 8, 2021 13:52
[ upstream commit a8b3480 ]

It was not clear if kernel v5.8 has problem with libceph or if 5.8 fixes the problem.
Redo the sentence based on feedback to make it more clear and easy to read.

Signed-off-by: Ville Ojamo <bluikko@users.noreply.github.com>

Signed-off-by: Glib Smaga <code@gsmaga.com>
[ upstream commit 27fd5cc ]

Signed-off-by: Stijn Smits <stijn@stijn98s.nl>

Signed-off-by: Glib Smaga <code@gsmaga.com>
[ upstream commit 83d30de ]

Having these environment variables allows the cherry-pick script to be
used on other projects that are not Cilium.

Signed-off-by: André Martins <andre@cilium.io>

Signed-off-by: Glib Smaga <code@gsmaga.com>
[ upstream commit 9e4d84b ]

The Kubernetes' client User-Agent was never set and it would always
fallback to the default value. This commit fixes this issue and now all
Cilium components will correctly present their User-Agent.

Fixes: b31ed33 ("Add k8s client qps and burst as cli flags for the operator")
Signed-off-by: André Martins <andre@cilium.io>

Signed-off-by: Glib Smaga <code@gsmaga.com>
[ upstream commit f6f2406 ]

coredns < 1.7.0 has a bug that makes the services resolution to become
out-of-sync with the last state from Kubernetes in case coredns
suffers from a disconnection with kube-apiserver [1]. This bug is fixed on
all versions equal and above 1.7.0. [2]

In our CI this affects all Kubernetes jobs 1.18 and below and can result
in flaky tests that have the result in the following similar logs:

```
service IP retrieved from DNS (10.101.253.144) does not match the IP for the service stored in Kubernetes (10.108.15.225)
```

[1] coredns/coredns#3587
[2] coredns/coredns#3924

Signed-off-by: André Martins <andre@cilium.io>

Signed-off-by: Glib Smaga <code@gsmaga.com>
@glibsm glibsm force-pushed the pr/v1.8-backport-2021-10-04 branch from 63e8b1d to 976ba4a Compare October 8, 2021 20:52
@glibsm glibsm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Oct 8, 2021
@glibsm
Copy link
Member Author

glibsm commented Oct 8, 2021

/test-backport-1.8

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 11, 2021
@errordeveloper errordeveloper merged commit c498e35 into v1.8 Oct 11, 2021
@errordeveloper errordeveloper deleted the pr/v1.8-backport-2021-10-04 branch October 11, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants