node: Skip ipcache for remote node IPs if IPsec is enabled #17511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b2db7f to
f7ba86a
Compare
michi-covalent
approved these changes
Oct 4, 2021
christarazi
approved these changes
Oct 5, 2021
This new method will be used in the following commit to check if tunneling is enabled from the node package. Signed-off-by: Paul Chaignon <paul@cilium.io>
Before this commit, if IPsec is enabled, we add all remote node IP addresses to the ipcache of all nodes, regardless of whether enable-remote-node-identity is true or false. This commit reverts that behavior to only add those IP addresses if remote-node identities, node encryption, or encryption+tunneling are enabled. If encryption+native routing is enabled, we don't need to expose the remote node IP addresses via the ipcache. Signed-off-by: Paul Chaignon <paul@cilium.io>
f7ba86a to
842637a
Compare
|
/test |
christarazi
approved these changes
Oct 12, 2021
|
The GKE node was running an outdated Go version. This has been fixed this morning. |
|
This will additionally mean pod->node is not encrypted for routing use cases. I think this is OK. |
jrfastab
approved these changes
Oct 13, 2021
@jrfastab That's already the case, no? |
|
If there is a keyID in the ipcache entry we would use it. But, I just checked and we don't include keys in nodeIP entries so you are correct as far as I can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pull request, if IPsec is enabled, we add all remote node IP addresses to the ipcache of all nodes, regardless of whether
enable-remote-node-identityis true or false.This pull request reverts that behavior to only add those IP addresses if remote-node identities, node encryption, or encryption+tunneling are enabled. If encryption+native routing is enabled, we don't need to expose the remote node IP addresses via the ipcache.