Skip to content

v1.9 backports 2021-10-11 #17567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2021
Merged

v1.9 backports 2021-10-11 #17567

merged 2 commits into from
Oct 13, 2021

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Oct 11, 2021 •
edited by joestringer
Loading

Once this PR is merged, you can update the PR labels via:

$ for pr in 17477; do contrib/backporting/set-labels.py $pr done 1.9; done

@errordeveloper errordeveloper requested a review from a team as a code owner October 11, 2021 11:05
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.9 kind/backports This PR provides functionality previously merged into master. labels Oct 11, 2021
@aanm @errordeveloper
install/kubernetes: set right version on Makefile
916047d 
[ upstream commit 5d37a2f ]

The Makefile contains all component versions which are then used to
generate the helm charts. This commit fixes some of those versions that
got out-of-sync with the right versions.

Fixes: 206105f ("helm: use 'quay.io/cilium/certgen:v0.1.5'")
Fixes: 09f3c81 ("helm: upgrade envoy to v1.18.4 for hubble-ui")
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper force-pushed the pr/v1.9-backport-2021-10-11 branch from 74e734d to 916047d Compare October 11, 2021 11:10
@errordeveloper
Copy link
Contributor Author

@aanm I have excluded ecffb2d from this, as .github/workflows/tests-smoke.yaml doesn't exist in 1.9.

@errordeveloper
Copy link
Contributor Author

@aanm so it looks like these two are failing smoke tests are failing, presumably the changes ecffb2d are supposed to be applied to different workflow configs?

@errordeveloper
Copy link
Contributor Author

/test-backport-1.9

@errordeveloper errordeveloper force-pushed the pr/v1.9-backport-2021-10-11 branch from 4dfa2a9 to f046fbf Compare October 12, 2021 11:32
@errordeveloper
Copy link
Contributor Author

/test-backport-1.9

@errordeveloper
install: Update image digests
73375b8 
This is related to commit 916047d.

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper force-pushed the pr/v1.9-backport-2021-10-11 branch from f046fbf to 73375b8 Compare October 12, 2021 11:57
@errordeveloper
Copy link
Contributor Author

errordeveloper commented Oct 12, 2021 •
edited by maintainer-s-little-helper bot
Loading

/test-backport-1.9

Job 'Cilium-PR-K8s-1.17-kernel-4.9' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

[empty]

Failure Output

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.17-kernel-4.9 so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-1.13-kernel-4.9' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sPolicyTest Basic Test Traffic redirections to proxy Tests proxy visibility interactions with policy lifecycle operations

Failure Output

FAIL: "app2-b7f694678-l9484" cannot curl "10.0.0.141"

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.13-kernel-4.9 so I can create a new GitHub issue to track it.

@errordeveloper
Copy link
Contributor Author

@aanm so it looks like these two are failing smoke tests are failing, presumably the changes ecffb2d are supposed to be applied to different workflow configs?

Looks like all that was needs is updating all quick-install manifests.

@errordeveloper errordeveloper requested a review from aanm October 12, 2021 12:35
aanm
aanm approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ilya!

@errordeveloper errordeveloper mentioned this pull request Oct 13, 2021
Closed
@errordeveloper
Copy link
Contributor Author

errordeveloper commented Oct 13, 2021 •
edited
Loading

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Oct 13, 2021 •
edited
Loading

/test-1.12-netnext

Re-run it as there appears to be a vagrant error.

14:32:38  Progress state: NS_ERROR_INVALID_ARG
14:32:38  VBoxManage: error: Appliance import failed
14:32:38  VBoxManage: error: Code NS_ERROR_INVALID_ARG (0x80070057) - Invalid argument value (extended info not available)
14:32:38  VBoxManage: error: Context: "RTEXITCODE handleImportAppliance(HandlerArg*)" at line 957 of file VBoxManageAppliance.cpp

@errordeveloper errordeveloper mentioned this pull request Oct 13, 2021
Closed
@errordeveloper
Copy link
Contributor Author

/test-1.12-netnext

@errordeveloper
Copy link
Contributor Author

Will merge since backports are exempt from zero-flake strategy.

@errordeveloper errordeveloper added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 13, 2021
@errordeveloper errordeveloper merged commit 58ef3dc into cilium:v1.9 Oct 13, 2021
@errordeveloper errordeveloper deleted the pr/v1.9-backport-2021-10-11 branch October 13, 2021 13:44
@joestringer joestringer mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errordeveloper @aanm