verifier-test.sh: allow for empty FOO_PROGS #17408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verifier-test.sh allows users to pass what programs to test via environment variables. However, these variables are only used if they are not unset and not empty. This means that we, for example, cannot pass XDP_PROGS="" to avoid verifiying any xdp progs. This patch modifies the check to only ignore the environment variables if they are unset. So now we can use verifier-test.sh to test only a single program: root# TC_PROGS="bpf_host" XDP_PROGS="" CG_PROGS="" ./test/bpf/verifier-test.sh => Loading bpf_host.c:from-netdev... => Loading bpf_host.c:from-host... => Loading bpf_host.c:to-netdev... => Loading bpf_host.c:to-host... Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
joestringer
reviewed
Sep 15, 2021
joestringer
approved these changes
Sep 15, 2021
|
test-me-please Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
pchaigno
approved these changes
Sep 15, 2021
This was referenced Sep 24, 2021
borkmann
approved these changes
Sep 28, 2021
|
Jenkins page expired: |
|
k8s-1.16-kernel-netnext failed with:
Considering that and the fact that both tests are unaffected by the changes in this PR, I'm marking ready to merge. |
|
Marking this pull request for backport into v1.9 and v1.10 given we'll also backport the extension of K8sVerifier (cf. #17470) which relies on this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifier-test.sh allows users to pass what programs to test via
environment variables. However, these variables are only used if they
are not unset and not empty. This means that we, for example, cannot
pass XDP_PROGS="" to avoid verifiying any xdp progs.
This patch modifies the check to only ignore the environment variables
if they are unset.
So now we can use verifier-test.sh to test only a single program:
root# TC_PROGS="bpf_host" XDP_PROGS="" CG_PROGS="" ./test/bpf/verifier-test.sh
=> Loading bpf_host.c:from-netdev...
=> Loading bpf_host.c:from-host...
=> Loading bpf_host.c:to-netdev...
=> Loading bpf_host.c:to-host...
Signed-off-by: Kornilios Kourtis kornilios@isovalent.com