Skip to content

test/K8sVerifier: Cover several datapath configurations #17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2021
Merged

test/K8sVerifier: Cover several datapath configurations #17470

merged 2 commits into from
Oct 19, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Sep 24, 2021 •
edited
Loading

This pull request extends K8sVerifier to cover several datapath configurations. The first commit reworks K8sVerifier to compile and load each BPF program independently, each based on their own configuration file stored in bpf/complexity-tests/[kernel]/[bpf_program].txt. The second commit adds new datapath configurations to test.

Updates: #5058.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. dont-merge/blocked Another PR must be merged before this one. kind/complexity-issue Relates to BPF complexity or program size issues labels Sep 24, 2021
@pchaigno pchaigno force-pushed the k8sverifier-test-multiple-configs branch 2 times, most recently from 9d02a76 to a0cca43 Compare September 24, 2021 18:02
@pchaigno pchaigno mentioned this pull request Sep 24, 2021
Open
6 tasks
@pchaigno pchaigno changed the title test/K8sverifier: Cover several datapath configurations test/K8sVerifier: Cover several datapath configurations Sep 28, 2021
This was referenced Sep 28, 2021
Closed
Closed
Closed
@pchaigno pchaigno force-pushed the k8sverifier-test-multiple-configs branch 3 times, most recently from 71b1309 to fcca811 Compare October 11, 2021 12:11
@pchaigno pchaigno mentioned this pull request Oct 11, 2021
Merged
@pchaigno pchaigno force-pushed the k8sverifier-test-multiple-configs branch from fcca811 to 19333de Compare October 13, 2021 19:51
@pchaigno pchaigno removed the dont-merge/blocked Another PR must be merged before this one. label Oct 13, 2021
@pchaigno pchaigno requested a review from kkourt October 13, 2021 22:23
@pchaigno pchaigno marked this pull request as ready for review October 13, 2021 22:23
@pchaigno pchaigno requested a review from a team October 13, 2021 22:23
@pchaigno pchaigno requested review from a team as code owners October 13, 2021 22:23
@pchaigno pchaigno requested a review from christarazi October 13, 2021 22:23
christarazi
christarazi approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pchaigno pchaigno mentioned this pull request Oct 14, 2021
Merged
kkourt
kkourt approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@pchaigno
Copy link
Member Author

Tests are passing except for ConformanceAKS which is consistently failing on master and unaffected by changes in this pull request anyway. Reviews are in. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 19, 2021
@joamaki joamaki merged commit 9acd9d3 into cilium:master Oct 19, 2021
@pchaigno pchaigno deleted the k8sverifier-test-multiple-configs branch October 19, 2021 08:56
@joamaki joamaki mentioned this pull request Oct 20, 2021
Merged
@kkourt kkourt mentioned this pull request Oct 21, 2021
Closed
@nebril nebril mentioned this pull request Oct 28, 2021
Merged
This was referenced Nov 8, 2021
Merged
Merged
@joestringer joestringer mentioned this pull request Dec 10, 2021
Merged
@joestringer joestringer mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/complexity-issue Relates to BPF complexity or program size issues ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pchaigno @kkourt @christarazi @joamaki @nebril @aanm @qmonnet