Skip to content

test: Skip Istio test on k8s <1.17 #17445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

test: Skip Istio test on k8s <1.17 #17445

merged 1 commit into from
Sep 27, 2021

Conversation

jrajahalme
Copy link
Member

Istio 1.10 requires at least k8s version 1.17.

Signed-off-by: Jarno Rajahalme jarno@isovalent.com

@jrajahalme
test: Skip Istio test on k8s <1.17
366a56b 
Istio 1.10 requires at least k8s version 1.17.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. needs-backport/1.8 labels Sep 21, 2021
@jrajahalme jrajahalme requested review from a team as code owners September 21, 2021 08:17
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 21, 2021
@jrajahalme
Copy link
Member Author

jrajahalme commented Sep 21, 2021 •
edited by maintainer-s-little-helper bot
Loading

test-me-please

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sBookInfoDemoTest Bookinfo Demo Tests bookinfo demo

Failure Output

FAIL: Pods are not ready after timeout

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sKafkaPolicyTest Kafka Policy Tests KafkaPolicies

Failure Output

FAIL: DNS entry of kafka-service is not ready after timeout

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.16-net-next so I can create a new GitHub issue to track it.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Sep 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2021
@kaworu kaworu mentioned this pull request Sep 23, 2021
Merged
@pchaigno
Copy link
Member

Given all test failures are clearly unrelated (not even the changed test) and reviews are in, I'm marking ready to merge. This PR is to fix a test failure, so an exception to the zero-flake strategy.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 24, 2021
@jibi jibi merged commit 3992048 into cilium:master Sep 27, 2021
This was referenced Sep 27, 2021
Merged
Merged
@joestringer joestringer mentioned this pull request Oct 13, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jrajahalme @pchaigno @kaworu @nebril @qmonnet @jibi @errordeveloper @joestringer @aanm