Skip to content

fix(docs): bandwidth-manager install error #17338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2021
Merged

fix(docs): bandwidth-manager install error #17338

merged 1 commit into from
Sep 9, 2021

Conversation

withlin
Copy link
Contributor

@withlin withlin commented Sep 8, 2021

fix(docs): bandwidth-manager install error

Signed-off-by: JinLin Fu withlin@apache.org

@withlin withlin requested a review from a team September 8, 2021 09:28
@withlin withlin requested a review from a team as a code owner September 8, 2021 09:28
@maintainer-s-little-helper
Copy link

Commit 91ee7b6fefd332e3598b341dc46a38aaa420c457 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 8, 2021
borkmann
borkmann approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting!

@joestringer joestringer added needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels Sep 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 8, 2021
@joestringer
Copy link
Member

Thanks for the submission! To satisfy the bot, can you add the Signoff line from your PR into the commit message itself using git commit --amend and repush?

@withlin
fix bandwidth-manager install error
6ecd5eb 
Signed-off-by: JinLin Fu withlin@apache.org
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 9, 2021
@withlin
Copy link
Contributor Author

withlin commented Sep 9, 2021

Done

@withlin withlin requested a review from joestringer September 9, 2021 08:01
joestringer
joestringer approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FYI in future if you need it, you can use git commit -s for --signoff and it will inject the signoff into the commit message based on your git.user configuration, then you can just configure it once and don't need to type it out each time.

@joestringer joestringer merged commit 712af8e into cilium:master Sep 9, 2021
@kaworu kaworu mentioned this pull request Sep 14, 2021
Merged
@joestringer joestringer mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@joestringer joestringer joestringer approved these changes

@bmcustodio bmcustodio bmcustodio approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@jrfastab jrfastab

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@withlin @joestringer @borkmann @bmcustodio @kaworu @jrfastab