v1.8: .github: Remove conformance test from lint workflow #17334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e36816d to
06d5e3c
Compare
Recently, upstream gomega moved to Go 1.16 which is apparently not
available in the workflow environment here. This causes problems like:
# github.com/onsi/gomega/matchers
go/src/github.com/onsi/gomega/matchers/have_http_body_matcher.go:84:30: undefined: io.ReadAll
go/src/github.com/onsi/gomega/matchers/have_http_status_matcher.go:81:16: undefined: io.ReadAll
# github.com/onsi/gomega/gmeasure
go/src/github.com/onsi/gomega/gmeasure/cache.go:69:18: undefined: os.ReadDir
go/src/github.com/onsi/gomega/gmeasure/cache.go:90:18: undefined: os.ReadDir
We already run the K8sConformance one-node test as part of the regular
jenkins runs, so this run in the GitHub workflow is duplicate. Newer
releases don't run this test as part of the linting since it's not
linting anyway, so we can just drop these steps to resolve the issue and
rely on Jenkins to provide feedback on this particular test.
For what it's worth, I did briefly try pinning to ginkgo@v1.15.2 and
gomega@v1.15.0 to resolve this but Go would complain about not wanting
to pull a specific version into the $GOPATH, or otherwise complain about
the vendor dependencies conflicting if I tried to use GO111MODULE.
Seemed simpler in the end to just drop this logic from the GitHub action.
Signed-off-by: Joe Stringer <joe@cilium.io>
06d5e3c to
e3db2a6
Compare
aanm
approved these changes
Sep 15, 2021
|
@joestringer both ginkgo and gomega are binaries used in a git repository. We could use |
|
test-backport-1.8 |
|
Oh, I forgot the reason why I didn't run full CI in the first place - This only changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, upstream gomega moved to Go 1.16 which is apparently not
available in the workflow environment here. This causes problems like:
We already run the K8sConformance one-node test as part of the regular
jenkins runs, so this run in the GitHub workflow is duplicate. Newer
releases don't run this test as part of the linting since it's not
linting anyway, so we can just drop these steps to resolve the issue and
rely on Jenkins to provide feedback on this particular test.
For what it's worth, I did briefly try pinning to ginkgo@v1.15.2 and
gomega@v1.15.0 to resolve this but Go would complain about not wanting
to pull a specific version into the $GOPATH, or otherwise complain about
the vendor dependencies conflicting if I tried to use GO111MODULE.
Seemed simpler in the end to just drop this logic from the GitHub action.
Fixes: #17263