-
Notifications
You must be signed in to change notification settings - Fork 3.4k
v1.10 backports 2021-09-14 #17392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.10 backports 2021-09-14 #17392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cbd5482
to
f4f2932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/runtime: Look into log errors after test start #17351
LGTM.
@nbusseneau added #17143 to the backport to fix ConformanceKind1.19, please take a look. |
test-backport-1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for my changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My changes LGTM, thanks!
gke-stable failed due to a DNS timeout
k8s-1.16-kernel-netnext failed due to an istio timeout, but we should skip istio tests on k8s 1.16 (see #17445 for context).
|
777db48
to
3659cde
Compare
[ upstream commit 4c87394 ] Update Cilium Istio integration to Istio release 1.10.4. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 3992048 ] Istio 1.10 requires at least k8s version 1.17. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
…apache.org [ upstream commit 712af8e ] Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 38994b0 ] When running runtime tests locally sometimes the test fail as level=error log entries are found that are the result of cilium-agent restarts during provisioning. This is similar to the fix done in cilium#14529. Signed-off-by: Jussi Maki <jussi@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit d3ff998 ] Previously, the BPF-based masquerading (--enable-bpf-masquerade=true) was wrongly masquerading replies from a pod to an outside when the outside had initiated a connection. This was possible when e.g., the outside had a route to the pod cidr. To fix this, we introduce a lightweight CT lookup function ct_is_reply4() which checks whether a given flow is a reply. The lookup function is called in snat_v4_needed(). As a side note, I've tried to move the port extraction to a separate function, but unfortunately it hits complexity issues on the 4.19 kernel in the "K8sDatapathConfig AutoDirectNodeRoutes Check direct connectivity with per endpoint routes" suite: BPF program is too large. Processed 131073 insn libbpf: failed to load program 'handle_to_container' libbpf: failed to load object '624_next/bpf_lxc.o' Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 55bfba9 ] Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 4b92d2d ] Previously, they were failing due to our datapath masquerading replies from pod to outside. As it got fixed in the previous commit, we can enable BPF-based masquerading. This will also gives us some coverage for the fix. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 6418ade ] This pulls in a few fixes around ioctl wrappers wrt. unsafe.Pointer usage and fixes ifreqEthtool to be correctly padded. Ref. golang/sys@e5e7981 Ref. golang/sys@b450225 Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit d82ac6f ] Use the ioctl wrapper provided in the golang.org/x/sys/unix package with the correctly padded ifreqData struct, rather than providing our own wrapper and struct which is incorrectly padded. Also add a simple unit test and make sure the package is only built on Linux. Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 82469c3 ] The egress gateway doesn't exactly require our kube-proxy replacement to be enabled. It only requires BPF masquerading which itself requires BPF NodePort. Enabling KPR is just an easy way to enable BPF NodePort. Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit e0da2e4 ] Signed-off-by: Tom Payne <tom@isovalent.com> Co-authored-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit 2202dae ] In cilium#16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
[ upstream commit acf3431 ] This change updates cilium-cli to 0.9.1 in github action workflows files. Signed-off-by: Maciej Kwiek <maciej@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Istio backports look OK.
test-backport-1.10 |
cilium-cli
version to v0.8.6 #17143 (@nbusseneau) ✔️Once this PR is merged, you can update the PR labels via: