bpf/Makefile: Enable setting complexity options #17364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bpf/Makefile, we use environment variables MAX_XXX_OPTIONS to define
the options to use when trying to maximize the program sizes for
complexity tests. This commit simply makes it possible to override these
variables from the command line, to generate different programs for
complexity tests. For example, one can run:
$ MAX_HOST_OPTIONS="-DENABLE_IPV4 -DENABLE_IPV6" make -C bpf bpf_host.o
Signed-off-by: Paul Chaignon <paul@cilium.io>
joestringer
approved these changes
Sep 13, 2021
|
The BPF compilation test is passing and the pull request received a review covering the only team review request. Marking ready to merge. |
6 tasks
|
Marking this pull request for backport into v1.9 and v1.10 given we'll also backport the extension of K8sVerifier (cf. #17470) which relies on this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
bpf/Makefile, we use environment variablesMAX_XXX_OPTIONSto define the options to use when trying to maximize the program sizes for complexity tests. This commit simply makes it possible to override these variables from the command line, to generate different programs for complexity tests. For example, one can run:@kkourt I think that's all that is needed to address the first point of both of our TODO lists in #5058: