Skip to content

jenkinsfiles: Don't display nulls in current build display name #17258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2021
Merged

jenkinsfiles: Don't display nulls in current build display name #17258

merged 1 commit into from
Sep 13, 2021

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Aug 30, 2021

Signed-off-by: Tom Payne tom@isovalent.com

@twpayne twpayne added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/misc This PR makes changes that have no direct user impact. labels Aug 30, 2021
@twpayne twpayne requested a review from nbusseneau August 30, 2021 14:34
@twpayne twpayne requested a review from a team as a code owner August 30, 2021 14:34
nbusseneau
nbusseneau reviewed Sep 10, 2021
View reviewed changes
@twpayne @nbusseneau
jenkinsfiles: Don't display nulls in current build display name
50812d1 
Signed-off-by: Tom Payne <tom@isovalent.com>
Co-authored-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
nbusseneau approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nbusseneau
Copy link
Member

Note; this will have to be backported if we want it to apply where the jobs are currently displaying null values (which is older stable branches).

@twpayne twpayne added needs-backport/1.9 ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 13, 2021
@kaworu kaworu merged commit e0da2e4 into cilium:master Sep 13, 2021
@kaworu kaworu mentioned this pull request Sep 14, 2021
Merged
@kaworu kaworu mentioned this pull request Sep 14, 2021
Merged
@kaworu kaworu mentioned this pull request Sep 14, 2021
Merged
@joestringer joestringer mentioned this pull request Oct 13, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@twpayne @nbusseneau @kaworu @errordeveloper @joestringer @aanm