Skip to content

Conversation

nbusseneau
Copy link
Member

CLI 0.8.6 added new L7 tests coverage, which consistently fails on EKS with IPsec enabled when it should be working.

We add test temporary exceptions until we fix the issue.

More details in #17139.

CLI 0.8.6 added new L7 tests coverage, which consistently fails on EKS
with IPsec enabled when it should be working.

We add test temporary exceptions until we fix the issue.

More details in #17139.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 11, 2021
@nbusseneau nbusseneau requested review from a team as code owners August 11, 2021 16:45
--test '!client-egress-l7,!echo-ingress-l7'
# workaround for L7 tests issues on EKS with IPsec enabled
# TODO: remove both test exceptions once:
# - https://github.com/cilium/cilium/issues/17139 is fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we check the regression also concerns v1.10?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet -- I will do so as part of triaging. I've decided to include it anyway so as to avoid a second PR if I confirm it's present there as well.

@nbusseneau
Copy link
Member Author

Link to test run of workflow changes: https://github.com/cilium/cilium/actions/runs/1120889617
The test was successful even though it is marked as skipped due to hitting the job timeout during teardown after the tests were run (remark: we probably should increase either increase the timeout now that we have more tests and it's taking even longer to run, or do not wait for eksctl delete to complete since it's asynchronous anyway).

Removing temporary test commit and marking as ready-to-merge as all reviews are in and this PR does not need to run any other CI.

@nbusseneau nbusseneau force-pushed the pr/workflows-add-l7-exception-eks-ipsec branch from 62b8f37 to 9491df2 Compare August 11, 2021 18:12
@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 11, 2021
@ti-mo ti-mo merged commit 095bc07 into master Aug 13, 2021
@ti-mo ti-mo deleted the pr/workflows-add-l7-exception-eks-ipsec branch August 13, 2021 14:53
This was referenced Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants